* [dpdk-dev] [PATCH] eal: correct error log for alarm
@ 2019-06-04 16:31 Xiaolong Ye
2019-06-05 6:51 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-05 7:18 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
0 siblings, 2 replies; 8+ messages in thread
From: Xiaolong Ye @ 2019-06-04 16:31 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Xiaolong Ye, stable
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
lib/librte_eal/linux/eal/eal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 161399619..10e2887ca 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
}
if (rte_eal_alarm_init() < 0) {
- rte_eal_init_alert("Cannot init interrupt-handling thread");
+ rte_eal_init_alert("Cannot init alarm");
/* rte_eal_alarm_init sets rte_errno on failure. */
return -1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm
2019-06-04 16:31 [dpdk-dev] [PATCH] eal: correct error log for alarm Xiaolong Ye
@ 2019-06-05 6:51 ` David Marchand
2019-06-05 6:49 ` Ye Xiaolong
2019-06-05 7:18 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
1 sibling, 1 reply; 8+ messages in thread
From: David Marchand @ 2019-06-05 6:51 UTC (permalink / raw)
To: Xiaolong Ye; +Cc: Ferruh Yigit, dev, dpdk stable
Hello,
On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> lib/librte_eal/linux/eal/eal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal.c
> b/lib/librte_eal/linux/eal/eal.c
> index 161399619..10e2887ca 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
> }
>
> if (rte_eal_alarm_init() < 0) {
> - rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> + rte_eal_init_alert("Cannot init alarm");
> /* rte_eal_alarm_init sets rte_errno on failure. */
> return -1;
> }
> --
> 2.17.1
>
>
The same applies to freebsd eal.
lib/librte_eal/freebsd/eal/eal.c: if (rte_eal_alarm_init() < 0) {
lib/librte_eal/freebsd/eal/eal.c- rte_eal_init_alert("Cannot
init interrupt-handling thread");
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm
2019-06-05 6:51 ` [dpdk-dev] [dpdk-stable] " David Marchand
@ 2019-06-05 6:49 ` Ye Xiaolong
2019-06-05 7:13 ` David Marchand
0 siblings, 1 reply; 8+ messages in thread
From: Ye Xiaolong @ 2019-06-05 6:49 UTC (permalink / raw)
To: David Marchand; +Cc: Ferruh Yigit, dev, dpdk stable
On 06/05, David Marchand wrote:
>Hello,
>
>On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>> lib/librte_eal/linux/eal/eal.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/linux/eal/eal.c
>> b/lib/librte_eal/linux/eal/eal.c
>> index 161399619..10e2887ca 100644
>> --- a/lib/librte_eal/linux/eal/eal.c
>> +++ b/lib/librte_eal/linux/eal/eal.c
>> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
>> }
>>
>> if (rte_eal_alarm_init() < 0) {
>> - rte_eal_init_alert("Cannot init interrupt-handling
>> thread");
>> + rte_eal_init_alert("Cannot init alarm");
>> /* rte_eal_alarm_init sets rte_errno on failure. */
>> return -1;
>> }
>> --
>> 2.17.1
>>
>>
>The same applies to freebsd eal.
>
>lib/librte_eal/freebsd/eal/eal.c: if (rte_eal_alarm_init() < 0) {
>lib/librte_eal/freebsd/eal/eal.c- rte_eal_init_alert("Cannot
>init interrupt-handling thread");
Er, yes, do I need to make another separate patch or just add the freebsd fix
into this patch?
Thanks,
Xiaolong
>
>
>--
>David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm
2019-06-05 6:49 ` Ye Xiaolong
@ 2019-06-05 7:13 ` David Marchand
2019-06-05 7:12 ` Ye Xiaolong
0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2019-06-05 7:13 UTC (permalink / raw)
To: Ye Xiaolong; +Cc: Ferruh Yigit, dev, dpdk stable
On Wed, Jun 5, 2019 at 8:58 AM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
> On 06/05, David Marchand wrote:
> >Hello,
> >
> >On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> >
> >> Fixes: af75078fece3 ("first public release")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >> ---
> >> lib/librte_eal/linux/eal/eal.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/lib/librte_eal/linux/eal/eal.c
> >> b/lib/librte_eal/linux/eal/eal.c
> >> index 161399619..10e2887ca 100644
> >> --- a/lib/librte_eal/linux/eal/eal.c
> >> +++ b/lib/librte_eal/linux/eal/eal.c
> >> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
> >> }
> >>
> >> if (rte_eal_alarm_init() < 0) {
> >> - rte_eal_init_alert("Cannot init interrupt-handling
> >> thread");
> >> + rte_eal_init_alert("Cannot init alarm");
> >> /* rte_eal_alarm_init sets rte_errno on failure. */
> >> return -1;
> >> }
> >> --
> >> 2.17.1
> >>
> >>
> >The same applies to freebsd eal.
> >
> >lib/librte_eal/freebsd/eal/eal.c: if (rte_eal_alarm_init() < 0) {
> >lib/librte_eal/freebsd/eal/eal.c- rte_eal_init_alert("Cannot
> >init interrupt-handling thread");
>
> Er, yes, do I need to make another separate patch or just add the freebsd
> fix
> into this patch?
>
$ git fixline 764bf268
Fixes: 764bf26873b9 ("add FreeBSD support")
$ git describe --contains 764bf268
v1.6.0r0~58
Both fixes are old enough to be relevant to the same stable branches (if we
want to backport this), so you can add it to this patch yes.
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm
2019-06-05 7:13 ` David Marchand
@ 2019-06-05 7:12 ` Ye Xiaolong
0 siblings, 0 replies; 8+ messages in thread
From: Ye Xiaolong @ 2019-06-05 7:12 UTC (permalink / raw)
To: David Marchand; +Cc: Ferruh Yigit, dev, dpdk stable
On 06/05, David Marchand wrote:
>On Wed, Jun 5, 2019 at 8:58 AM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
>
>> On 06/05, David Marchand wrote:
>> >Hello,
>> >
>> >On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>> >
>> >> Fixes: af75078fece3 ("first public release")
>> >> Cc: stable@dpdk.org
>> >>
>> >> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> >> ---
>> >> lib/librte_eal/linux/eal/eal.c | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/lib/librte_eal/linux/eal/eal.c
>> >> b/lib/librte_eal/linux/eal/eal.c
>> >> index 161399619..10e2887ca 100644
>> >> --- a/lib/librte_eal/linux/eal/eal.c
>> >> +++ b/lib/librte_eal/linux/eal/eal.c
>> >> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
>> >> }
>> >>
>> >> if (rte_eal_alarm_init() < 0) {
>> >> - rte_eal_init_alert("Cannot init interrupt-handling
>> >> thread");
>> >> + rte_eal_init_alert("Cannot init alarm");
>> >> /* rte_eal_alarm_init sets rte_errno on failure. */
>> >> return -1;
>> >> }
>> >> --
>> >> 2.17.1
>> >>
>> >>
>> >The same applies to freebsd eal.
>> >
>> >lib/librte_eal/freebsd/eal/eal.c: if (rte_eal_alarm_init() < 0) {
>> >lib/librte_eal/freebsd/eal/eal.c- rte_eal_init_alert("Cannot
>> >init interrupt-handling thread");
>>
>> Er, yes, do I need to make another separate patch or just add the freebsd
>> fix
>> into this patch?
>>
>
>$ git fixline 764bf268
>Fixes: 764bf26873b9 ("add FreeBSD support")
>$ git describe --contains 764bf268
>v1.6.0r0~58
>
>Both fixes are old enough to be relevant to the same stable branches (if we
>want to backport this), so you can add it to this patch yes.
>
Agree, will squash freebsd fix into this patch and send v2.
Thanks,
Xiaolong
>
>--
>David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2] eal: correct error log for alarm
2019-06-04 16:31 [dpdk-dev] [PATCH] eal: correct error log for alarm Xiaolong Ye
2019-06-05 6:51 ` [dpdk-dev] [dpdk-stable] " David Marchand
@ 2019-06-05 7:18 ` Xiaolong Ye
2019-06-05 7:31 ` David Marchand
1 sibling, 1 reply; 8+ messages in thread
From: Xiaolong Ye @ 2019-06-05 7:18 UTC (permalink / raw)
To: Ferruh Yigit, David Marchand, Bruce Richardson; +Cc: dev, Xiaolong Ye, stable
Fixes: af75078fece3 ("first public release")
Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
v2:
add freebsd fix suggested by David
lib/librte_eal/freebsd/eal/eal.c | 2 +-
lib/librte_eal/linux/eal/eal.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c
index c6ac9028f..a3b664125 100644
--- a/lib/librte_eal/freebsd/eal/eal.c
+++ b/lib/librte_eal/freebsd/eal/eal.c
@@ -663,7 +663,7 @@ rte_eal_init(int argc, char **argv)
}
if (rte_eal_alarm_init() < 0) {
- rte_eal_init_alert("Cannot init interrupt-handling thread");
+ rte_eal_init_alert("Cannot init alarm");
/* rte_eal_alarm_init sets rte_errno on failure. */
return -1;
}
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 161399619..10e2887ca 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
}
if (rte_eal_alarm_init() < 0) {
- rte_eal_init_alert("Cannot init interrupt-handling thread");
+ rte_eal_init_alert("Cannot init alarm");
/* rte_eal_alarm_init sets rte_errno on failure. */
return -1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v2] eal: correct error log for alarm
2019-06-05 7:18 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
@ 2019-06-05 7:31 ` David Marchand
2019-06-27 15:02 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2019-06-05 7:31 UTC (permalink / raw)
To: Xiaolong Ye; +Cc: Ferruh Yigit, Bruce Richardson, dev, dpdk stable
On Wed, Jun 5, 2019 at 9:28 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> Fixes: af75078fece3 ("first public release")
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>
> v2:
>
> add freebsd fix suggested by David
>
> lib/librte_eal/freebsd/eal/eal.c | 2 +-
> lib/librte_eal/linux/eal/eal.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/freebsd/eal/eal.c
> b/lib/librte_eal/freebsd/eal/eal.c
> index c6ac9028f..a3b664125 100644
> --- a/lib/librte_eal/freebsd/eal/eal.c
> +++ b/lib/librte_eal/freebsd/eal/eal.c
> @@ -663,7 +663,7 @@ rte_eal_init(int argc, char **argv)
> }
>
> if (rte_eal_alarm_init() < 0) {
> - rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> + rte_eal_init_alert("Cannot init alarm");
> /* rte_eal_alarm_init sets rte_errno on failure. */
> return -1;
> }
> diff --git a/lib/librte_eal/linux/eal/eal.c
> b/lib/librte_eal/linux/eal/eal.c
> index 161399619..10e2887ca 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
> }
>
> if (rte_eal_alarm_init() < 0) {
> - rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> + rte_eal_init_alert("Cannot init alarm");
> /* rte_eal_alarm_init sets rte_errno on failure. */
> return -1;
> }
> --
> 2.17.1
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v2] eal: correct error log for alarm
2019-06-05 7:31 ` David Marchand
@ 2019-06-27 15:02 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-06-27 15:02 UTC (permalink / raw)
To: Xiaolong Ye
Cc: dev, David Marchand, Ferruh Yigit, Bruce Richardson, dpdk stable
05/06/2019 09:31, David Marchand:
> On Wed, Jun 5, 2019 at 9:28 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
> > Fixes: af75078fece3 ("first public release")
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-27 15:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 16:31 [dpdk-dev] [PATCH] eal: correct error log for alarm Xiaolong Ye
2019-06-05 6:51 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-05 6:49 ` Ye Xiaolong
2019-06-05 7:13 ` David Marchand
2019-06-05 7:12 ` Ye Xiaolong
2019-06-05 7:18 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-06-05 7:31 ` David Marchand
2019-06-27 15:02 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).