From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A1118A0096 for ; Wed, 5 Jun 2019 18:29:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7449A1B9CB; Wed, 5 Jun 2019 18:29:39 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 99A651B9B4 for ; Wed, 5 Jun 2019 18:29:37 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id s11so15118967pfm.12 for ; Wed, 05 Jun 2019 09:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T7r8Zf4l56HV69IWN4wjfWxi6C1fAeuXGp1tznpWj/0=; b=Fhmi/L5YastaB+iBioGOkW4Evsme7RgcDDY8aKQOOSe+1knesiEEo+FUMGdeMs3blV JJtiTcEf8A6Q6EIiMAZ1kDBNkQN8bST8pRwBKEPiyPHkqt1vpkC3l7MGzvOM736Qv8Af o6bHa/lQkAB0kMZHzZ9Q4n//q13sCpvm//KKVKFKCvde1fS1/W2YzePyZxts+EmGWwDL GqZLeW/aCtDYua3RU0NvQYzexuRbTfM6YD0w05q5T5EGBD+4vNfqD4xAjyo91ltbAmhI wdCiBkOaBcN82M4F0GCvVFoHLr+43Yfxbdrc6+My+Tea7jcYzUE21ijhoV8Y5v9kT45z mTLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T7r8Zf4l56HV69IWN4wjfWxi6C1fAeuXGp1tznpWj/0=; b=Tv/cMy3vYituxY7olnC3KXCHX5roQri+0PKCwyOOlT7+XiUuwPxB3JCjlEsgkpOkxk nQECVV3U5tVgAKce1hpKQwLMBCmEmB3zyT//7cwzutDKr6jntrVZ7Rc/22j0CS+HUzJW srIoS5qQWxwPY4tXpN8qnhtyAsBYsTL26CpC9o+g7R3iB1JND6Ei+dIgtN4pCP3Hgwnq L3yxe7naZrluLxGR7iE+HA6iu4TYWaFjh/JrdezE2vkJd6uzDTya7A5Pswxmjk1HePsY b5N/Djs+LyNEP0zBpEe96GHaK3w0D4TtVDgygJIbxcxpNP1VdNacgtrpgezYczIehlyN TY/w== X-Gm-Message-State: APjAAAWR/GtC4VBdGApQktxigpppI+z+Xz0PZjvsZsdDyPcayUKK9oWl F8fUXTveMs+w0V61dyP3ZpeKSA== X-Google-Smtp-Source: APXvYqyN1DKvUQ9tf1N88n5hfX3wZUzWFnPmyneVoTRWJibm1u6wTFJJGOsGfHHwSwemgqyv0FR5bw== X-Received: by 2002:a62:770e:: with SMTP id s14mr17287667pfc.150.1559752176723; Wed, 05 Jun 2019 09:29:36 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o15sm28424702pfh.53.2019.06.05.09.29.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 09:29:36 -0700 (PDT) Date: Wed, 5 Jun 2019 09:29:33 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: , Rami Rosen Message-ID: <20190605092933.2fe6f48a@hermes.lan> In-Reply-To: <6e011b50-8168-ddeb-6c31-869dee837333@solarflare.com> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190605010852.28395-1-stephen@networkplumber.org> <20190605010852.28395-2-stephen@networkplumber.org> <6e011b50-8168-ddeb-6c31-869dee837333@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/6] net/rte_ether: deinline non-critical functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 5 Jun 2019 11:44:42 +0300 Andrew Rybchenko wrote: > On 6/5/19 4:08 AM, Stephen Hemminger wrote: > > Formatting ethernet address and getting a random value are > > not in critical path so they should not be inlined. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Rami Rosen > > Meson build is lost plus one nit below. > Other than that: > > Reviewed-by: Andrew Rybchenko > > [...] > > > diff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map > > index 26c06e7c7ae7..dae6e420cded 100644 > > --- a/lib/librte_net/rte_net_version.map > > +++ b/lib/librte_net/rte_net_version.map > > @@ -13,6 +13,13 @@ DPDK_17.05 { > > > > } DPDK_16.11; > > > > +DPDK_19.08 { > > + global: > > + > > + eth_random_addr; > > + eth_format_addr; > > rte_ prefix is lost > > > +} DPDK_17.05; > > + > > EXPERIMENTAL { > > global: > > > Fixing those now for v4