From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 167BEA0096
for <public@inbox.dpdk.org>; Wed, 5 Jun 2019 18:33:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CB2061B9D3;
Wed, 5 Jun 2019 18:33:17 +0200 (CEST)
Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com
[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 8691B1B9CB
for <dev@dpdk.org>; Wed, 5 Jun 2019 18:33:16 +0200 (CEST)
Received: by mail-pg1-f195.google.com with SMTP id 196so12686967pgc.6
for <dev@dpdk.org>; Wed, 05 Jun 2019 09:33:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=aRQylzx+Nwds4jprID5v8XTDxGVwz28DfycVtmKOJeg=;
b=DfSBW+pLoRJ9oCSGOoNTayXXM+vTq5PauqFjtlcC1QW0LOsGHvcx5oe7kyH0BVHP1F
qiNwhRHB3LNibA+zsz7MPSr4CoGO8egXIvHjFVTFv722JGFNk4yNa5oCNoNgyBZf3Pbl
JRQ17m4c4hDAvJ75V1h1FwY+IG44XjTcOytwW/nSZOh5mIP7hJ3H8mN0zhOe6GaCXmAl
1Q2Q/2kIyeWtfkj9e7aenE3m+e26zi4tpKfBsd5UTycItnHLO6L7t+/91gVjUuom6HPL
pO6DgMI4IL3/vs0+E2zBhTWKkUM1vrvdskAkNsGfoMjlsc3TJE7xsKmIs49wgMt28okC
FClQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=aRQylzx+Nwds4jprID5v8XTDxGVwz28DfycVtmKOJeg=;
b=aCeTzoa/c6HYfZ+3AEBo30NnNtLnQeH/8QdaFLMNWGTWMU0zc3yjuqjd4G12erELsG
pMeqlG8QPyTRqDNP1tfBYaHjy5OlJNNjn2lRZIL3k8FPVBTI7TClEDvso6t5ReiB0sCo
SSYOI2s6rYTVCQ4TJvq3l2Qcp6mDjQwh/l/9bVRk8BONrm5j5i4r16LynfFqTBu8s/TO
QSYMT4pCXNtOBPlKL/T55vs00AkK9a9IR+8XbNs7+4AliHWyWt9s9nuislMnqXfog4G6
42AmWDkvf5XeV4oz4CBFI9eUGrZdLLM8k53+NlHijBjW3i4pDJSfeFR2lIr1jsh6d4aI
RSvQ==
X-Gm-Message-State: APjAAAV49aaCyMY7ATpZcxHRnY3uzazvz7BXRIORGRgf2UI5r1Iwt8Fc
8CSBlkNHDUIANUdiUQEJL+3czg==
X-Google-Smtp-Source: APXvYqxa0jWg+7BvLBDRKK2EspdRE1L6Bcu7jU+JjQlPFB0X5qVAMh3fvVNi9g3UgHUrNxq7Q8cQmQ==
X-Received: by 2002:a65:5ccb:: with SMTP id b11mr5628364pgt.172.1559752395792;
Wed, 05 Jun 2019 09:33:15 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id u123sm22146786pfu.67.2019.06.05.09.33.15
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Wed, 05 Jun 2019 09:33:15 -0700 (PDT)
Date: Wed, 5 Jun 2019 09:33:13 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: <dev@dpdk.org>
Message-ID: <20190605093313.4f0afc13@hermes.lan>
In-Reply-To: <e73b1aa1-6a03-aabd-736b-61702f65f9d3@solarflare.com>
References: <20190516180427.17270-1-stephen@networkplumber.org>
<20190605010852.28395-1-stephen@networkplumber.org>
<20190605010852.28395-4-stephen@networkplumber.org>
<e73b1aa1-6a03-aabd-736b-61702f65f9d3@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 3/6] ethdev: use rte_eth_unformat_addr
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Wed, 5 Jun 2019 11:59:52 +0300
Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> On 6/5/19 4:08 AM, Stephen Hemminger wrote:
> > Use rte_eth_unformat_addr, so that ethdev can be built and work
> > without the cmdline library. The dependency on cmdline was
> > an arrangement of convenience anyway.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> [...]
>
> > diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c
> > index 873a653532ad..6338355e2557 100644
> > --- a/lib/librte_ethdev/rte_class_eth.c
> > +++ b/lib/librte_ethdev/rte_class_eth.c
> > @@ -4,7 +4,6 @@
> >
> > #include <string.h>
> >
> > -#include <cmdline_parse_etheraddr.h>
> > #include <rte_class.h>
> > #include <rte_compat.h>
> > #include <rte_errno.h>
> > @@ -43,19 +42,13 @@ static int
> > eth_mac_cmp(const char *key __rte_unused,
> > const char *value, void *opaque)
> > {
> > - int ret;
> > struct rte_ether_addr mac;
> > const struct rte_eth_dev_data *data = opaque;
> > struct rte_eth_dev_info dev_info;
> > uint32_t index;
> >
> > /* Parse devargs MAC address. */
> > - /*
> > - * cannot use ether_aton_r(value, &mac)
> > - * because of include conflict with rte_ether.h
>
> Why not ether_aton_r()? Isn't conflict resolved now after patch series
> from Olivier?
> I think it would be nice to explain it in the changeset description.
The problem with using ether_aton_r is that it does not accept the same
input formats as old code.