DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, ybrustin@cisco.com, tiwei.bie@intel.com,
	jfreimann@redhat.com, david.marchand@redhat.com
Cc: stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v3 3/4] net/virtio: fix segment data len in mergeable packed Rx path
Date: Wed,  5 Jun 2019 12:00:38 +0200	[thread overview]
Message-ID: <20190605100039.18029-4-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20190605100039.18029-1-maxime.coquelin@redhat.com>

Head segment data_len field is wrongly summed with the length
of all the segments of the chain, whereas it should be the
length of of the first segment only.

Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues")
Cc: stable@dpdk.org

Reported-by: Yaroslav Brustinov <ybrustin@cisco.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/net/virtio/virtio_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index acee4fcc07..358cc86627 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -1875,7 +1875,6 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
 			rxm->data_len = (uint16_t)(len[i]);
 
 			rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
-			rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);
 
 			if (prev)
 				prev->next = rxm;
@@ -1912,7 +1911,6 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
 				prev->next = rxm;
 				prev = rxm;
 				rx_pkts[nb_rx]->pkt_len += len[extra_idx];
-				rx_pkts[nb_rx]->data_len += len[extra_idx];
 				extra_idx += 1;
 			}
 			seg_res -= rcv_cnt;
-- 
2.21.0


  parent reply	other threads:[~2019-06-05 10:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 10:00 [dpdk-dev] [PATCH v3 0/4] et/virtio: Fix packet segmentation bug Maxime Coquelin
2019-06-05 10:00 ` [dpdk-dev] [PATCH v3 1/4] net/virtio: fix segmented packet issue in in-order Rx path Maxime Coquelin
2019-06-05 10:00 ` [dpdk-dev] [PATCH v3 2/4] net/virtio: fix segmented packet issue in mergeable " Maxime Coquelin
2019-06-05 10:00 ` Maxime Coquelin [this message]
2019-06-05 11:16   ` [dpdk-dev] [PATCH v3 3/4] net/virtio: fix segment data len in mergeable packed " Jens Freimann
2019-06-05 11:34     ` Maxime Coquelin
2019-06-05 10:00 ` [dpdk-dev] [PATCH v3 4/4] net/virtio: remove useless pointers checks Maxime Coquelin
2019-06-06  7:15   ` Ye Xiaolong
2019-06-06  7:31     ` Maxime Coquelin
2019-06-05 13:25 ` [dpdk-dev] [PATCH v3 0/4] et/virtio: Fix packet segmentation bug Tiwei Bie
2019-06-06  9:31 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605100039.18029-4-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jfreimann@redhat.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=ybrustin@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).