From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 49571A0096 for ; Wed, 5 Jun 2019 12:02:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2402A1BA6F; Wed, 5 Jun 2019 12:02:32 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 703D21B9F9 for ; Wed, 5 Jun 2019 12:02:30 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 03:02:29 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga006.jf.intel.com with SMTP; 05 Jun 2019 03:02:27 -0700 Received: by (sSMTP sendmail emulation); Wed, 05 Jun 2019 11:02:26 +0100 Date: Wed, 5 Jun 2019 11:02:26 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: konstantin.ananyev@intel.com, adrien.mazarguil@6wind.com, dev@dpdk.org, Marcin Smoczynski Message-ID: <20190605100226.GA1550@bricha3-MOBL.ger.corp.intel.com> References: <20190514140416.4192-1-marcinx.smoczynski@intel.com> <20190514140416.4192-2-marcinx.smoczynski@intel.com> <1847238.2vmrsgWslk@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1847238.2vmrsgWslk@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 05, 2019 at 11:37:34AM +0200, Thomas Monjalon wrote: > Marcin, please remind to use --in-reply-to to have next versions > in the same thread. Thanks > > Bruce, Konstantin, Adrien, any opinion about this patch? > Looks a reasonable cleanup to me. The fact that the same macros are being defined in multiple places implies that it would be good to consolidate them. > > 14/05/2019 16:04, Marcin Smoczynski: > > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > > explicitly in its build recipe, it restricts visibility of a non POSIX > > features subset, such as IANA protocol numbers (IPPROTO_* macros). > > Non standard features are enabled by default for DPDK both for Linux > > thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. However > > using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes > > __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different feature > > sets visibility for Linux and FreeBSD. It restricts from using IPPROTO > > macros in public headers, such as rte_ip.h, despite the fact they are > > already widely used in sources. > > > > Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets > > which enforces feature sets visibility unification between Linux and > > FreeBSD. > > > > Add single -D_GNU_SOURCE to config/meson.build as a project argument > > instead of adding separate directive for each project subtree. > > > > This patch solves the problem of build breaks for [1] on FreeBSD [2] > > following the discussion [3]. > > > > [1] https://mails.dpdk.org/archives/dev/2019-May/131885.html > > [2] http://mails.dpdk.org/archives/test-report/2019-May/082263.html > > [3] https://mails.dpdk.org/archives/dev/2019-May/132110.html > > > > Signed-off-by: Marcin Smoczynski > Acked-by: Bruce Richardson