[dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD

[dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD

[David Marchand]

Caught on FreeBSD 12:

/usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
  struct in_addr ip_src,ip_dst; /* source and dest address */
                 ^~~~~~

POSIX defines netinet/in.h as the right header for in_addr.
Linux seems fine without it but let's include it explicitly.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 examples/multi_process/client_server_mp/mp_server/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c
index 9a8e422..b1e8a8c 100644
--- a/examples/multi_process/client_server_mp/mp_server/main.c
+++ b/examples/multi_process/client_server_mp/mp_server/main.c
@@ -11,6 +11,7 @@
 #include <inttypes.h>
 #include <sys/queue.h>
 #include <errno.h>
+#include <netinet/in.h>
 #include <netinet/ip.h>
 #include <signal.h>
 
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD

[Thomas Monjalon]

05/06/2019 11:06, David Marchand:
> Caught on FreeBSD 12:
> 
> /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
>   struct in_addr ip_src,ip_dst; /* source and dest address */
>                  ^~~~~~
> 
> POSIX defines netinet/in.h as the right header for in_addr.
> Linux seems fine without it but let's include it explicitly.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Please could you add a "Fixes:" tag with Cc stable?

Re: [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD

[David Marchand]

On Wed, Jun 5, 2019 at 11:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 05/06/2019 11:06, David Marchand:
> > Caught on FreeBSD 12:
> >
> > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete
> type
> >   struct in_addr ip_src,ip_dst; /* source and dest address */
> >                  ^~~~~~
> >
> > POSIX defines netinet/in.h as the right header for in_addr.
> > Linux seems fine without it but let's include it explicitly.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Please could you add a "Fixes:" tag with Cc stable?
>

We did not build the examples before.
Not sure what to tag as the "culprit".
The one that adds FreeBSD support ?


-- 
David Marchand

Re: [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD

[Thomas Monjalon]

05/06/2019 11:36, David Marchand:
> On Wed, Jun 5, 2019 at 11:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 05/06/2019 11:06, David Marchand:
> > > Caught on FreeBSD 12:
> > >
> > > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete
> > type
> > >   struct in_addr ip_src,ip_dst; /* source and dest address */
> > >                  ^~~~~~
> > >
> > > POSIX defines netinet/in.h as the right header for in_addr.
> > > Linux seems fine without it but let's include it explicitly.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> >
> > Please could you add a "Fixes:" tag with Cc stable?
> >
> 
> We did not build the examples before.
> Not sure what to tag as the "culprit".
> The one that adds FreeBSD support ?

I was thinking about the patch using in_addr so we can have a meaningful backport.

Re: [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD

[David Marchand]

On Wed, Jun 5, 2019 at 11:52 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 05/06/2019 11:36, David Marchand:
> > On Wed, Jun 5, 2019 at 11:26 AM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > > 05/06/2019 11:06, David Marchand:
> > > > Caught on FreeBSD 12:
> > > >
> > > > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete
> > > type
> > > >   struct in_addr ip_src,ip_dst; /* source and dest address */
> > > >                  ^~~~~~
> > > >
> > > > POSIX defines netinet/in.h as the right header for in_addr.
> > > > Linux seems fine without it but let's include it explicitly.
> > > >
> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > >
> > > Please could you add a "Fixes:" tag with Cc stable?
> > >
> >
> > We did not build the examples before.
> > Not sure what to tag as the "culprit".
> > The one that adds FreeBSD support ?
>
> I was thinking about the patch using in_addr so we can have a meaningful
> backport.
>

I can't find the reason why this header is included and it goes back to the
initial release.
Removed this header include with a 1.2.3r0 and it builds fine :-)


-- 
David Marchand

[dpdk-dev] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD

[David Marchand]

Caught on FreeBSD 12:

/usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
  struct in_addr ip_src,ip_dst; /* source and dest address */
                 ^~~~~~

On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
But actually, this header is not used in the example, just remove it.

Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changelog since v1:
- took the opposite approach, rather than fix the netinet/ip.h inclusion,
  dropped it as it is unused
- added Fixes: tag

---
 examples/multi_process/client_server_mp/mp_server/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c
index 9a8e422..0150533 100644
--- a/examples/multi_process/client_server_mp/mp_server/main.c
+++ b/examples/multi_process/client_server_mp/mp_server/main.c
@@ -11,7 +11,6 @@
 #include <inttypes.h>
 #include <sys/queue.h>
 #include <errno.h>
-#include <netinet/ip.h>
 #include <signal.h>
 
 #include <rte_common.h>
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD

[Bruce Richardson]

On Wed, Jun 05, 2019 at 01:30:26PM +0200, David Marchand wrote:
> Caught on FreeBSD 12:
> 
> /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
>   struct in_addr ip_src,ip_dst; /* source and dest address */
>                  ^~~~~~
> 
> On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
> But actually, this header is not used in the example, just remove it.
> 
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

This should knock off one of the CI build errors once merged, I hope!
Thanks for doing the patch.

/Bruce

Re: [dpdk-dev] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD

[Thomas Monjalon]

05/06/2019 14:50, Bruce Richardson:
> On Wed, Jun 05, 2019 at 01:30:26PM +0200, David Marchand wrote:
> > Caught on FreeBSD 12:
> > 
> > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
> >   struct in_addr ip_src,ip_dst; /* source and dest address */
> >                  ^~~~~~
> > 
> > On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
> > But actually, this header is not used in the example, just remove it.
> > 
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> This should knock off one of the CI build errors once merged, I hope!
> Thanks for doing the patch.

Applied, thanks