From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C6C5AA0096 for ; Wed, 5 Jun 2019 14:53:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92CB21BB40; Wed, 5 Jun 2019 14:53:09 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 900A51BB3D for ; Wed, 5 Jun 2019 14:53:08 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 05:53:07 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga005.fm.intel.com with SMTP; 05 Jun 2019 05:53:05 -0700 Received: by (sSMTP sendmail emulation); Wed, 05 Jun 2019 13:53:04 +0100 Date: Wed, 5 Jun 2019 13:53:04 +0100 From: Bruce Richardson To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, david.marchand@redhat.com, jfreimann@redhat.com, zhihong.wang@intel.com, konstantin.ananyev@intel.com, mattias.ronnblom@ericsson.com Message-ID: <20190605125304.GF1550@bricha3-MOBL.ger.corp.intel.com> References: <20190529130420.6428-1-maxime.coquelin@redhat.com> <20190529130420.6428-6-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190529130420.6428-6-maxime.coquelin@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3 5/5] eal/x86: force inlining of all memcpy and mov helpers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 29, 2019 at 03:04:20PM +0200, Maxime Coquelin wrote: > Some helpers in the header file are forced inlined other are > only inlined, this patch forces inline for all. > > It will avoid it to be embedded as functions when called multiple > times in the same object file. For example, when we added packed > ring support in vhost-user library, rte_memcpy_generic got no > more inlined. > > Signed-off-by: Maxime Coquelin Acked-by: Bruce Richardson