From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 13336A0096 for ; Fri, 7 Jun 2019 07:11:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7D8B3798; Fri, 7 Jun 2019 07:11:53 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id C081AF64 for ; Fri, 7 Jun 2019 07:11:52 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id c5so340644pll.11 for ; Thu, 06 Jun 2019 22:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xsqzBAC6/ONwBh79gkFQ+foJV0ZZOtO3ZZ41NEj7XFM=; b=nUiYesLHcG/fq3xGtnx8cS5c4regAnQ/HjeIyfi2p/Fgb40CRdE56Wx1mJAN5KzOoI 9nYpfD5CpzL4MArFAnqjkdu9RkjOzd6DQ7nwWbd++WArMZHN1sCGiziN5D8QjNlyRnKW SEUm8FD+YafyjLwJtMrap9wF2+Fi5/a67K37sfb5nh4XC8nbenqmqj5iChkT9ikxaNGu vw7W0rk7NsaQe1Kn8Fkdhx54YYWU6gF1g0LA1oGFLxnibldMnyjlM571+aJcfjs0qMFq U5S0FW7U9zllIoPWm9aYmyZK3qQzB/cgtdbcE+BafzFxEqrkdQ7o15fyzesRqQqotLdw iI0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xsqzBAC6/ONwBh79gkFQ+foJV0ZZOtO3ZZ41NEj7XFM=; b=QZbsZpvarmoqoKguPMxa8hfhO66/Fn4JFt7pQVB37P752j/2XEGDQ4WQq2gStJmuu2 cfBGbiBF3Ruff6a8P03XA3KTTosb94ija6LorXmS/1WE0Bewv6rMPwIIJO6/y2TwlSsk loTh6JrmivVmSPC0stfisvJ4A2WULR/mIXwVO40BuRHEOX+cj9/K9s5ASHYBC20UST8M azOOLXo39WVj8sw8SGbTia3EKdwyTq0vJ+p4X+Gij4/V8EP7UEfIZ0lOSbEEtF7Hx7/v wjI/KFe3Q+a9y/4ApsVgJXSud63UE1YpMLsNa0N9qpxBEMiGUq3BfI1HwZL2A+Wqazpy uMmQ== X-Gm-Message-State: APjAAAUZHSgjHuaoa7I4IKpmgG4cVU4Fey4tbbetZxGgFtTikxl+gPE3 uTRvypdb4kzSB+uroI6BsvA= X-Google-Smtp-Source: APXvYqyWQcMZ3v6i7RpHHOjIYB4EiyZgxNd1k6teALG43uzG9NvCjdlO45yvcixGDNDmHGnvVWEDbg== X-Received: by 2002:a17:902:e2:: with SMTP id a89mr54333728pla.210.1559884311998; Thu, 06 Jun 2019 22:11:51 -0700 (PDT) Received: from gmail.com ([115.113.156.2]) by smtp.gmail.com with ESMTPSA id 85sm955287pgb.52.2019.06.06.22.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jun 2019 22:11:51 -0700 (PDT) Date: Fri, 7 Jun 2019 10:41:47 +0530 From: Nithin Dabilpuram To: Ferruh Yigit Cc: jerinj@marvell.com, dev@dpdk.org, Kiran Kumar K , Vamsi Attunuru Message-ID: <20190607051147.GA14536@gmail.com> References: <20190602152434.23996-1-jerinj@marvell.com> <20190602152434.23996-57-jerinj@marvell.com> <29465841-ccde-086d-467e-c99d84fc5ea3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29465841-ccde-086d-467e-c99d84fc5ea3@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH v1 56/58] net/octeontx2: add device stop and close operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 06, 2019 at 05:23:12PM +0100, Ferruh Yigit wrote: > On 6/2/2019 4:24 PM, jerinj@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add device stop, close and reset operations. > > > > Signed-off-by: Nithin Dabilpuram > > Signed-off-by: Vamsi Attunuru > > <...> > > > @@ -1792,6 +1844,24 @@ otx2_eth_dev_uninit(struct rte_eth_dev *eth_dev, bool mbox_close) > > return 0; > > } > > > > +static void > > +otx2_nix_dev_close(struct rte_eth_dev *eth_dev) > > +{ > > + otx2_eth_dev_uninit(eth_dev, true); > > +} > > 'close' should free all PMD resources, with 'RTE_ETH_DEV_CLOSE_REMOVE' flag > ethdev API can free the ethdev level allocated memory itself. > Agreed, we are adhering to the spec and handling close with RTE_ETH_DEV_CLOSE_REMOVE flag behavior where close cannot return error and even rte_eth_dev will itself be freed. Do you see any issue ? > >