From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4AA28A0096 for ; Sat, 8 Jun 2019 02:24:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C3FA1BC98; Sat, 8 Jun 2019 02:24:33 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id B2D841BC93 for ; Sat, 8 Jun 2019 02:24:31 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id 19so1214997pfa.4 for ; Fri, 07 Jun 2019 17:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jMiYw+Ga3ySVzzDdIFMI8ZXBpiw/Y5U6V6avEEO85Pc=; b=OPZupF0Ww00yHjHHxyXu+zwXr3RkKDi7DIVqAysunzG8boK5pOv/aG1DBT9dhzaaGp Uh8kpTBoW3STuSJ3SIHMlcCNlQhTw7EFsuxU8Qrnx6zgzeSUsXUbWOvZmX8M1wyXDzqV kUoCN62N6YAfD6E/A7LSUR13B2IAJDu9bQr7PbRdBE1jI4VuleTTXLkwaRWqAlR78kVZ B49tijniODJUz+GXdSWu+f7qRoj4EbbwbB2XMDIyDjN0XqGPf2jCDh6imHkzZNa4c2HO hnRNsXozgfTHNSMAuePx9J6lDoE63CeFbS+ScESAD53Hg00KB3/mr2ef2reX6TaIpkWw Ky/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jMiYw+Ga3ySVzzDdIFMI8ZXBpiw/Y5U6V6avEEO85Pc=; b=a/+FR/OFoep4b8WR62AqBSreCawOqZyfHD1cwyuTpFSL2yYmYyR7WeCyCPMo1Q/pny I+8lAsWF+sBWJZa0gc0z1sfSy4C6m6goSqRGIoy/AiWJZShePscaVtSKZ7fuQxWAOnoH 4YL3nuj7LgVWEpvqmaa34APS04PxWiXfYzaKWJ/SLr5QxII/M6RSFc74RYXWqH6tpijG OmnQ16bsIOY1kD3NCK1W9n2BsYauRQyR4rURNXZS5m7wTH5u8lqdlR2hg+dZnMb6/OO8 6cGhl6AtsHMuRyGPAdLrbt+Yjgs2gMaSEd4ohdCzV6dof9TraVQQKA6np7pXxuwwz/CA 0wZA== X-Gm-Message-State: APjAAAWz3pmBBwrQVL6f4w2VyvYn/IUgvDD7oG0P91Ar0e14ITUPKUIC oDGxiND+xpKHRO8zSeeIhNxyEQ== X-Google-Smtp-Source: APXvYqzOJhQV18Hq3xbqgvJSzZ/CvG1QLSULXVhv52cKvAN4D/ywMNnWWfKiP9Wgb9ntru/NZFUGYQ== X-Received: by 2002:a17:90a:aa85:: with SMTP id l5mr8210184pjq.69.1559953470796; Fri, 07 Jun 2019 17:24:30 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n184sm4017999pfn.21.2019.06.07.17.24.30 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 17:24:30 -0700 (PDT) Date: Fri, 7 Jun 2019 17:24:24 -0700 From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org Message-ID: <20190607172424.1a557090@hermes.lan> In-Reply-To: <20190608002003.19942-3-stephen@networkplumber.org> References: <20190608002003.19942-1-stephen@networkplumber.org> <20190608002003.19942-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/9] kni: use netdev_alloc_skb X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 7 Jun 2019 17:19:56 -0700 Stephen Hemminger wrote: > +++ b/kernel/linux/kni/kni_net.c > @@ -340,16 +340,13 @@ kni_net_rx_normal(struct kni_dev *kni) > data_kva = kva2data_kva(kva); > kni->va[i] = pa2va(kni->pa[i], kva); > > - skb = dev_alloc_skb(len + 2); > + skb = netdev_alloc_skb(dev, len + 2); The +2 is no longer needed. will update in next version