From: Stephen Hemminger <stephen@networkplumber.org>
To: ferruh.yigit@intel.com
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 5/9] kni: drop unused group_id and device_id
Date: Fri, 7 Jun 2019 17:19:59 -0700 [thread overview]
Message-ID: <20190608002003.19942-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20190608002003.19942-1-stephen@networkplumber.org>
Kni devices no longer are restricted to PCI and device_id
in kni_dev is no longer used.
The group_id is set but never used.
The fields do need to stay in the ABI (dev_info) but
kernel can ignore them.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
kernel/linux/kni/kni_dev.h | 4 ----
kernel/linux/kni/kni_misc.c | 1 -
2 files changed, 5 deletions(-)
diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h
index ca3b07678b96..e39af97feaa7 100644
--- a/kernel/linux/kni/kni_dev.h
+++ b/kernel/linux/kni/kni_dev.h
@@ -40,7 +40,6 @@ struct kni_dev {
struct list_head list;
int status;
- uint16_t group_id; /* Group ID of a group of KNI devices */
uint32_t core_id; /* Core ID to bind */
char name[RTE_KNI_NAMESIZE]; /* Network device name */
struct task_struct *pthread;
@@ -49,9 +48,6 @@ struct kni_dev {
wait_queue_head_t wq;
struct mutex sync_lock;
- /* PCI device id */
- uint16_t device_id;
-
/* kni device */
struct net_device *net_dev;
diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index af18c67c422f..6a206d883c0d 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
kni = netdev_priv(net_dev);
kni->net_dev = net_dev;
- kni->group_id = dev_info.group_id;
kni->core_id = dev_info.core_id;
strncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);
--
2.20.1
next prev parent reply other threads:[~2019-06-08 0:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 0:19 [dpdk-dev] [PATCH 0/9] kni: cleanups and improvements Stephen Hemminger
2019-06-08 0:19 ` [dpdk-dev] [PATCH 1/9] kni: don't need stubs for rx_mode or ioctl Stephen Hemminger
2019-06-08 0:19 ` [dpdk-dev] [PATCH 2/9] kni: use netdev_alloc_skb Stephen Hemminger
2019-06-08 0:24 ` Stephen Hemminger
2019-06-08 0:19 ` [dpdk-dev] [PATCH 3/9] kni: drop unused field Stephen Hemminger
2019-06-08 0:19 ` [dpdk-dev] [PATCH 4/9] kni: don't keep stats in kni_net Stephen Hemminger
2019-06-08 0:19 ` Stephen Hemminger [this message]
2019-06-08 0:20 ` [dpdk-dev] [PATCH 6/9] kni: drop unused status element Stephen Hemminger
2019-06-08 0:20 ` [dpdk-dev] [PATCH 7/9] kni: use proper type for kni fifo's Stephen Hemminger
2019-06-08 0:20 ` [dpdk-dev] [PATCH 8/9] kni: return -EFAULT if copy_from_user fails Stephen Hemminger
2019-06-08 0:20 ` [dpdk-dev] [PATCH 9/9] doc: update KNI documentation Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608002003.19942-6-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).