From: Tianfei zhang <tianfei.zhang@intel.com>
To: dev@dpdk.org, rosen.xu@intel.com, stable@dpdk.org
Cc: Tianfei zhang <tianfei.zhang@intel.com>
Subject: [dpdk-dev] [PATCH v3 2/4] raw/ifpga_rawdev: fix logically dead code
Date: Mon, 10 Jun 2019 23:51:54 +0800 [thread overview]
Message-ID: <20190610155156.313-2-tianfei.zhang@intel.com> (raw)
In-Reply-To: <20190610155156.313-1-tianfei.zhang@intel.com>
add temporary variable in max10_reg_write().
Coverity issue: 337927
Fixes: 96ebfcf ("raw/ifpga/base: add SPI and MAX10 device driver")
Cc: stable@dpdk.org
Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
---
drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
index f354ee4b6..3ff6575d7 100644
--- a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
+++ b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
@@ -17,11 +17,13 @@ int max10_reg_read(unsigned int reg, unsigned int *val)
int max10_reg_write(unsigned int reg, unsigned int val)
{
+ unsigned int tmp = val;
+
if (!g_max10)
return -ENODEV;
return spi_transaction_write(g_max10->spi_tran_dev,
- reg, 4, (unsigned char *)&val);
+ reg, 4, (unsigned char *)&tmp);
}
struct intel_max10_device *
@@ -57,7 +59,7 @@ intel_max10_device_probe(struct altera_spi_device *spi,
/* set PKVL Polling manually in BBS */
ret = max10_reg_write(PKVL_POLLING_CTRL, 0x3);
- if (ret) {
+ if (ret != 0) {
dev_err(dev, "%s set PKVL polling fail\n", __func__);
goto spi_tran_fail;
}
--
2.17.1
next prev parent reply other threads:[~2019-06-10 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 15:51 [dpdk-dev] [PATCH v3 1/4] raw/ifpga_rawdev: fix use of untrusted scalar value Tianfei zhang
2019-06-10 15:51 ` Tianfei zhang [this message]
2019-06-11 2:30 ` [dpdk-dev] [PATCH v3 2/4] raw/ifpga_rawdev: fix logically dead code Xu, Rosen
2019-06-10 15:51 ` [dpdk-dev] [PATCH v3 3/4] raw/ifpga_rawdev/base: fix bit fields definition Tianfei zhang
2019-06-11 2:31 ` Xu, Rosen
2019-06-10 15:51 ` [dpdk-dev] [PATCH v3 4/4] raw/ifpga_rawdev/base: fix miss physical address Tianfei zhang
2019-06-11 2:31 ` Xu, Rosen
2019-06-11 2:29 ` [dpdk-dev] [PATCH v3 1/4] raw/ifpga_rawdev: fix use of untrusted scalar value Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610155156.313-2-tianfei.zhang@intel.com \
--to=tianfei.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).