From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B9D3CA00E6 for <public@inbox.dpdk.org>; Tue, 11 Jun 2019 22:54:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADB7E1D065; Tue, 11 Jun 2019 22:54:25 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 55A4D1D05D for <dev@dpdk.org>; Tue, 11 Jun 2019 22:54:24 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id d126so8188756pfd.2 for <dev@dpdk.org>; Tue, 11 Jun 2019 13:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RBaniFssqv7LNTym+L1LEV7wyH5qAxw8bEPLxJxmV8A=; b=llD8PJsIfFBOeH1xc0pezQ73tgXabPg3t7GBvhDsY90ecgL4BTrDUXHhiL/9ecpMAv 3ZAW4T3BsB7Cz/g9put1O9dz7MOy/QR+y00x9bpTdFrfUCdqNHACcVCjx2CD8JxSCFHg KA55/wGzWgRm3rX6Wh0Rx3T2TU7nWpVqntIqGJOLwYdBAxA/uSyPkl16lO4RFcZiMoK5 mPeTBX26+nJhSICBFVG/8ap40KUNvJI8nW2Kpaouq+1XvxuRJHBcYbIc5235BLyT5rDY I7UjzMrIgcEfpz1tIIoOaljKrWx7PGWblEWlEk5vICxZQwGgCCbZaMe1zlzLefHGGSee +eMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RBaniFssqv7LNTym+L1LEV7wyH5qAxw8bEPLxJxmV8A=; b=AHDol7e8UIStVW6RNW8gRWUodDTMfCi221gJ4NZfIoskNqVIullb1iWASSgnHOJ/VR /sl07VvBhRNiDRCy5SeajbJ3qfMox23CNgD+UPXZmQx2Y3XR9pPM87ib6cDqBch8c4ZA hzbwo7pJ18ftKBml5GHUS03sAh8DX93n1uCMPSEPmL1Us+yWtCOzCVULhwr3vFnvzjqN DahpshXrIQ6RYAmCHzAGFCz6yr32PKc013BP59ECdYkRaDUzw9DCnyHcjuQGkjV37o3K OaZKyVfCNKj1xV5sznTrcSajrlzBO/8aBHkXhXqeICnjhU9nZcf59uyn8o3At3Q4cE9U orgg== X-Gm-Message-State: APjAAAUHohB2hW+HSPC4ZXnqEvldGiPd/rccRncMqIwRzyT80wcuqOsz uAQ8jvWv7sjzds4K8D/408zDcw== X-Google-Smtp-Source: APXvYqyicOIV/rsO9eRJMK490s8hFPndcoR+r34uco9dPUawGmH76fpaaNxAVaP+RpnhodRcWfzTlQ== X-Received: by 2002:a65:4544:: with SMTP id x4mr22342436pgr.323.1560286463150; Tue, 11 Jun 2019 13:54:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z14sm18288917pgs.79.2019.06.11.13.54.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 13:54:23 -0700 (PDT) Date: Tue, 11 Jun 2019 13:54:16 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: ferruh.yigit@intel.com Cc: dev@dpdk.org Message-ID: <20190611135416.01f6dffc@hermes.lan> In-Reply-To: <20190610175155.21374-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, 10 Jun 2019 10:51:48 -0700 Stephen Hemminger <stephen@networkplumber.org> wrote: > While testing KNI with netvsc, saw lots of places more code > could be safely removed from KNI kernel driver. > > This is still mostly "putting lipstick on a pig" all users > would be better off using virtio_user rather than KNI. > > v2 - get rid of unnecessary padding, combine the unused field patches > > Stephen Hemminger (7): > kni: don't need stubs for rx_mode or ioctl > kni: use netdev_alloc_skb > kni: don't keep stats in kni_net > kni: drop unused fields > kni: use proper type for kni fifo's > kni: return -EFAULT if copy_from_user fails > doc: update KNI documentation > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- > kernel/linux/kni/kni_dev.h | 21 ++--- > kernel/linux/kni/kni_misc.c | 17 ++-- > kernel/linux/kni/kni_net.c | 79 +++++-------------- > 4 files changed, 38 insertions(+), 97 deletions(-) > Don't believe patchwork the patch is fine, it is getting falsely blamed for failures caused by other changes in ice, bnxt which fail FreeBSD build.