From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
To: dev@dpdk.org
Cc: Thinh Tran <thinhtr@linux.vnet.ibm.com>
Subject: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure
Date: Tue, 11 Jun 2019 16:44:12 -0500 [thread overview]
Message-ID: <20190611214412.18388-1-thinhtr@linux.vnet.ibm.com> (raw)
Using memory on the stack instead of on the heap by calling malloc
also avoid memory leak in case of test case failures
Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure")
Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
index 359c9e296..3250c2296 100644
--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
@@ -274,17 +274,14 @@ static int
test_rawdev_attr_set_get(void)
{
int ret;
- int *dummy_value;
+ int *dummy_value, set_value;
uint64_t ret_value;
/* Set an attribute and fetch it */
ret = rte_rawdev_set_attr(TEST_DEV_ID, "Test1", 100);
RTE_TEST_ASSERT(!ret, "Unable to set an attribute (Test1)");
- dummy_value = malloc(sizeof(int));
- if (!dummy_value)
- RTE_TEST_ASSERT(1, "Unable to allocate memory (dummy_value)");
-
+ dummy_value = &set_value;
*dummy_value = 200;
ret = rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uintptr_t)dummy_value);
@@ -294,11 +291,9 @@ test_rawdev_attr_set_get(void)
"Attribute (Test1) not set correctly (%" PRIu64 ")",
ret_value);
- free(dummy_value);
-
ret_value = 0;
ret = rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value);
- RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200,
+ RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), set_value,
"Attribute (Test2) not set correctly (%" PRIu64 ")",
ret_value);
--
2.21.0.windows.1
next reply other threads:[~2019-06-11 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 21:44 Thinh Tran [this message]
2019-06-12 5:35 ` Shreyansh Jain
2019-07-01 17:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611214412.18388-1-thinhtr@linux.vnet.ibm.com \
--to=thinhtr@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).