From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B649BA0471 for ; Mon, 17 Jun 2019 10:58:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37ED01BE91; Mon, 17 Jun 2019 10:58:45 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 240771BE5C; Mon, 17 Jun 2019 10:58:42 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 01:58:42 -0700 X-ExtLoop1: 1 Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.186]) by orsmga004.jf.intel.com with ESMTP; 17 Jun 2019 01:58:40 -0700 Date: Mon, 17 Jun 2019 23:40:51 +0800 From: Ye Xiaolong To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang Message-ID: <20190617154051.GE76301@intel.com> References: <1560758082-3479-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560758082-3479-1-git-send-email-david.marchand@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/17, David Marchand wrote: >This check on Linux environment has been added at a time when we already >had switched to using the boolean RTE_EXEC_ENV_LINUXAPP. >It was then missed when converting to RTE_EXEC_ENV_LINUX. > >Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA") >Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX") >Cc: stable@dpdk.org > >Signed-off-by: David Marchand >--- >If we backport this to 18.11, the fix is to switch to >RTE_EXEC_ENV_LINUXAPP. > >--- > examples/vdpa/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/examples/vdpa/Makefile b/examples/vdpa/Makefile >index 9d16d8e..ab2bbdf 100644 >--- a/examples/vdpa/Makefile >+++ b/examples/vdpa/Makefile >@@ -10,7 +10,7 @@ RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.conf > > include $(RTE_SDK)/mk/rte.vars.mk > >-ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") >+ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y) > $(info This application can only operate in a linux environment, \ > please change the definition of the RTE_TARGET environment variable) > all: >-- >1.8.3.1 > Reviewed-by: Xiaolong Ye