From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 2/2] net/qede: fix warnings from invalid assert
Date: Wed, 19 Jun 2019 11:22:17 -0700 [thread overview]
Message-ID: <20190619182217.8482-2-stephen@networkplumber.org> (raw)
In-Reply-To: <20190619182217.8482-1-stephen@networkplumber.org>
This driver had a bogus assert which could never happen.
This triggers "expression is always false warnings" with some
compilers which causes build failure.
Just remove it.
Fixes: 2af14ca79c0a ("net/qede: support 100G")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/qede/qede_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 84d898421bd4..82363e6eba93 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1426,7 +1426,6 @@ static void qede_poll_sp_sb_cb(void *param)
if (rc != 0) {
DP_ERR(edev, "Unable to start periodic"
" timer rc %d\n", rc);
- assert(false && "Unable to start periodic timer");
}
}
--
2.20.1
next prev parent reply other threads:[~2019-06-19 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 18:22 [dpdk-dev] [PATCH 1/2] net/bnx2x: " Stephen Hemminger
2019-06-19 18:22 ` Stephen Hemminger [this message]
2019-06-24 9:23 ` [dpdk-dev] [PATCH 2/2] net/qede: " Morten Brørup
2019-06-24 9:24 ` Morten Brørup
2019-06-19 22:56 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: " Rasesh Mody
2019-06-24 9:25 ` Morten Brørup
2019-06-24 11:31 ` Ferruh Yigit
2019-06-24 13:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619182217.8482-2-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).