From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id EB0D3A0471
for <public@inbox.dpdk.org>; Wed, 19 Jun 2019 21:00:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id EEFBF1D146;
Wed, 19 Jun 2019 21:00:06 +0200 (CEST)
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id CA74F1C38D
for <dev@dpdk.org>; Wed, 19 Jun 2019 21:00:02 +0200 (CEST)
Received: by mail-pg1-f194.google.com with SMTP id n2so161822pgp.11
for <dev@dpdk.org>; Wed, 19 Jun 2019 12:00:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=LyNzsR8H+QQKPGmEhnn+f4xkaZgLMnwHGhB18LvT0Ro=;
b=JJX6XnUGudw8aTj/Fc0zLOSu8/11wxkh8XhNNb0qw+09NMM/Se1yZ5thKKlFas71x7
CBN4S/N7SU7s3YObh76CeUcloJFichbDTb6kQ9t3ubGXJFwzy7ACErkn47rd1qozAvPb
RNyxM9JVQjITujUTL6unARaZXnKEFA+g5niS+M9BdJADGp5mfjLAgpqGmD0sOAnaUUmQ
SPgoFlTA01yRACqVaHYH1V/pT9avP9zU+Uk8iX8xEZwPFbH3Tc3fd3MLfu4YSgCWPmTz
UJvuCafE0dS3hLUKDyqbNUb0xsou+TAVG9eTwoQYGulWRxoAdwfTu2D1BFmZ8ahqW+w0
Tveg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=LyNzsR8H+QQKPGmEhnn+f4xkaZgLMnwHGhB18LvT0Ro=;
b=czyaU5zpTbjBKEjb9Y8Nvd1xUrnxDmIIHCbDxzfPqHvmVv3SayJ/RyDD9DAJJ8SgeC
g83l5VUcFbPh9fNg7pspEZpzAFcOztrrRA+meqfjbXwnpDD2IVPzsrVSGkOyTAJxB11F
fqdxy9PcbcGVG0ggtQKPTk3Gk5zNXNVtym6COyj2lVUr75KjsfQjRolyGgMIwjM+EBmp
/EL9nUL4Nn1xJofGd0TR/SlXnpANs6zIOmxHaaQedekf0KW4RNtbHRw1L0fazdaOcMXg
dvxLPgRMcXk9FaYgxGv93CxZ6W0Q2UqV5fvOUpAji6598rJzbWNWmywThQE126WHF28I
L9sA==
X-Gm-Message-State: APjAAAWPloggfYWddaQHTHSE8ti89GWm0e27M8Uqk8uIjJlW3pkMEgY0
hGeM4tvnH6IcbIDc9M+MFj1TnH5aevc=
X-Google-Smtp-Source: APXvYqw09K/R0vDiPqoqXses/LCvdVLAok7S6rdbHrgJPfjtyTeJst6zc+YZQ5uVdW4+23MO5KaQRw==
X-Received: by 2002:a63:1a03:: with SMTP id a3mr8631719pga.397.1560970801569;
Wed, 19 Jun 2019 12:00:01 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id g8sm18613397pfi.8.2019.06.19.12.00.00
(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
Wed, 19 Jun 2019 12:00:00 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 19 Jun 2019 11:59:51 -0700
Message-Id: <20190619185958.27306-2-stephen@networkplumber.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20190619185958.27306-1-stephen@networkplumber.org>
References: <20190610175155.21374-1-stephen@networkplumber.org>
<20190619185958.27306-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v4 1/8] kni: don't need stubs for rx_mode or ioctl
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Stephen Hemminger <sthemmin@microsoft.com>
The netdev subsystem already handles case where
network sevice does not support ioctl.
If device has no rx_mode hook it is not called.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
kernel/linux/kni/kni_net.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
index ad8365877cda..c86337d099ab 100644
--- a/kernel/linux/kni/kni_net.c
+++ b/kernel/linux/kni/kni_net.c
@@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev)
netif_wake_queue(dev);
}
-/*
- * Ioctl commands
- */
-static int
-kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
-{
- pr_debug("kni_net_ioctl group:%d cmd:%d\n",
- ((struct kni_dev *)netdev_priv(dev))->group_id, cmd);
-
- return -EOPNOTSUPP;
-}
-
-static void
-kni_net_set_rx_mode(struct net_device *dev)
-{
-}
-
static int
kni_net_change_mtu(struct net_device *dev, int new_mtu)
{
@@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = {
.ndo_change_rx_flags = kni_net_set_promiscusity,
.ndo_start_xmit = kni_net_tx,
.ndo_change_mtu = kni_net_change_mtu,
- .ndo_do_ioctl = kni_net_ioctl,
- .ndo_set_rx_mode = kni_net_set_rx_mode,
.ndo_get_stats = kni_net_stats,
.ndo_tx_timeout = kni_net_tx_timeout,
.ndo_set_mac_address = kni_net_set_mac,
--
2.20.1