From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 201EDA0471 for ; Wed, 19 Jun 2019 21:00:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E9611D177; Wed, 19 Jun 2019 21:00:15 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D8E1C1D12D for ; Wed, 19 Jun 2019 21:00:07 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id p184so138673pfp.7 for ; Wed, 19 Jun 2019 12:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eVpCCGqv4anpgjgB0iS05xOJSNV5B1c7nQVpCcdAfXk=; b=GImtclffayvUf//LAax4etCiT9hF5txTmRf9RIZJC+/XfiGXjkKtPtEMec+4EqYTKL L/igjL5ShHb6tgoBqdf0f4z/vbjkUJuXEK+Th2RdXBTjiCG3HtLazX3UKLNMZcokZwMR Lji3Y6Wu6ktjFus/0vjSukyvUnU2OrEHSNtDOTBzju9sYmL8rhQuHgNp0Pr9CHca7DsG 7uCRnAjRoqcXVbuJejJw6Ru4LZ5JsnF0F0NZOY3UUUyqckYsAhEPsse5QWGFjzPY7LXP 8J4myOQoHYswQDZmm7p9cFBkHi6PCjbklBlgBslw4b/r3d6o4Ce1tbDA3mgMhQUDHQCp 3t/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eVpCCGqv4anpgjgB0iS05xOJSNV5B1c7nQVpCcdAfXk=; b=mYosd/ybRq6HKjjh20rEWutBOEeYxrV3pp1a6seffmepu8BAFZeEXOiwjyXpaUn+ej 7rEvXWgy8xfPn343bNi4O4zoEOSkzWIgxkIbzXEIlotTrohOdjpygwWfYNCl5cNpLC9y IFHCWJWFGBX55HvS+l0dmylW0XCXT+PSS3n8tHYkohGj7ptbj+5T5xAFbzfViuGcxEz9 WWZKCdsN0Eq5xzGeLeUH5A+87TrpUcy3pU1EPPgUTidP/trGmk7kJMPJjL6bXE8jukEW nS1UZa2oiN4McIpCzS0hBizL4CL1h8/BtZovAG35KBppiVdd6ou3Lv34q5f1tScgoOQg uefQ== X-Gm-Message-State: APjAAAU83PnVGnmvaTQ59JC1GFHia4F3rWRC85swAKYReUj2ZyfKnX9I ORhpImsK4r1Y1Fgmg22ICSvSBpk5nhw= X-Google-Smtp-Source: APXvYqw2ohikQCjwU/VrKi3qpRwUMO3jRuA02UD6UuG/C1MjYuLFYKPvttoO/7z3esfjm2asfsRkqw== X-Received: by 2002:a63:1b46:: with SMTP id b6mr1493689pgm.183.1560970806455; Wed, 19 Jun 2019 12:00:06 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g8sm18613397pfi.8.2019.06.19.12.00.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 12:00:05 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 19 Jun 2019 11:59:54 -0700 Message-Id: <20190619185958.27306-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190619185958.27306-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190619185958.27306-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 4/8] kni: drop unused fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger The kni net structure only exists in driver no API/ABI. Several fields were either totally unused or set and never used. The fields in dev_info do need to stay in the ABI but kernel can ignore them. Signed-off-by: Stephen Hemminger kni: drop unused status element Yet another ethtool leftover. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 5 ----- kernel/linux/kni/kni_misc.c | 1 - 2 files changed, 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index 21e4b0d92368..f3e6c3ca4efa 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -39,8 +39,6 @@ struct kni_dev { /* kni list */ struct list_head list; - int status; - uint16_t group_id; /* Group ID of a group of KNI devices */ uint32_t core_id; /* Core ID to bind */ char name[RTE_KNI_NAMESIZE]; /* Network device name */ struct task_struct *pthread; @@ -79,9 +77,6 @@ struct kni_dev { /* mbuf size */ uint32_t mbuf_size; - /* synchro for request processing */ - unsigned long synchro; - /* buffers */ void *pa[MBUF_BURST_SZ]; void *va[MBUF_BURST_SZ]; diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index 1fc5eeb9c8ca..b59cf24c2184 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, kni = netdev_priv(net_dev); kni->net_dev = net_dev; - kni->group_id = dev_info.group_id; kni->core_id = dev_info.core_id; strncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE); -- 2.20.1