From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 2BFAEA0471
for <public@inbox.dpdk.org>; Wed, 19 Jun 2019 21:00:52 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id EDD031D17E;
Wed, 19 Jun 2019 21:00:17 +0200 (CEST)
Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com
[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 189191D163
for <dev@dpdk.org>; Wed, 19 Jun 2019 21:00:09 +0200 (CEST)
Received: by mail-pl1-f194.google.com with SMTP id e5so181836pls.13
for <dev@dpdk.org>; Wed, 19 Jun 2019 12:00:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=KIWdTWngvMzOCsjHwiLdXVCXjGw42l15HHKsPengMUk=;
b=MADSBUYwOXMfcIaW7+4bmLxhJ9DXSNR6ciUohNDe66nV9no3qm+haUqnAfQZuIukQQ
nIy0DXWq7Yd1OZXoKX+PI+EYAttjoqF88ntlNHDx0BSJ4jVs+EwQTOLKXbj65PaPpooG
7C/5szdKnogcRCMpCPnxhATxS8geS7QD9vQnOH1JO/8+hmhXHDx+9Bx7iZPvtR4AJd6w
7e+orx3F9Se/z8Dc84T5TuwRdbqMAgHTnYHd8HrGOW7+woFrppFZYNKkCarrZKkqaXLF
ZO8lvQO/KSjJ4Ss3OJr7wbGFKcgproA4crqG92s3oRq8nH1k7oOg+r0UtE0fGKHliR4n
id+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=KIWdTWngvMzOCsjHwiLdXVCXjGw42l15HHKsPengMUk=;
b=O1159wGvhxrkTO9jqiKFVjnR78TQ6ub/e7hBed1qOcJtDaEIhansvSKj/+1nFjtIL+
O9jQY+VAkvLoiua6xIZVjau4jRSqJAIctSkGYlkTts7nrbJ79WEdVyaLYqto/sx/xFFE
zo02DkdvK25BozyNI5vCNGrcyRgmNqiZUJs0nLIim4KBO/Pm5FfIg4zi0lfy/N6gFKon
R1OrMG8nyOK8hyFY/TerprmZsGN5rJgHYAX6GNP6H10hKfnOVJqyswL5QD1WyLh2XvzJ
3GKBGgwtJg6roB3vUWBiMP+rKErCFiqzs0eVdD5dZrUClxl1avxj6BNP6ruTntNJ65yn
H5Hw==
X-Gm-Message-State: APjAAAU6G+WeouDqh0yARmM81S7DtnAfoKjpuEn5SxAQSwHafD70Qzok
/+aIb9pFHcaYsqmZaEBND/H0GUKQ6fE=
X-Google-Smtp-Source: APXvYqzo0+otnyhmm6yrvd6qGJ6GAR0xVbKelb6kUGIKAdKNUL4BVKJhjAxAtd4hb7Z/bephoEkwGw==
X-Received: by 2002:a17:902:a411:: with SMTP id
p17mr62003213plq.104.1560970808067;
Wed, 19 Jun 2019 12:00:08 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id g8sm18613397pfi.8.2019.06.19.12.00.06
(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
Wed, 19 Jun 2019 12:00:07 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 19 Jun 2019 11:59:55 -0700
Message-Id: <20190619185958.27306-6-stephen@networkplumber.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20190619185958.27306-1-stephen@networkplumber.org>
References: <20190610175155.21374-1-stephen@networkplumber.org>
<20190619185958.27306-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v4 5/8] kni: use proper type for kni fifo's
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Stephen Hemminger <sthemmin@microsoft.com>
Using void * instead of proper type is unsafe practice.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
kernel/linux/kni/kni_dev.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h
index f3e6c3ca4efa..ceba5f73c1d9 100644
--- a/kernel/linux/kni/kni_dev.h
+++ b/kernel/linux/kni/kni_dev.h
@@ -51,22 +51,22 @@ struct kni_dev {
struct net_device *net_dev;
/* queue for packets to be sent out */
- void *tx_q;
+ struct rte_kni_fifo *tx_q;
/* queue for the packets received */
- void *rx_q;
+ struct rte_kni_fifo *rx_q;
/* queue for the allocated mbufs those can be used to save sk buffs */
- void *alloc_q;
+ struct rte_kni_fifo *alloc_q;
/* free queue for the mbufs to be freed */
- void *free_q;
+ struct rte_kni_fifo *free_q;
/* request queue */
- void *req_q;
+ struct rte_kni_fifo *req_q;
/* response queue */
- void *resp_q;
+ struct rte_kni_fifo *resp_q;
void *sync_kva;
void *sync_va;
--
2.20.1