From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BE2B9A0471 for ; Fri, 21 Jun 2019 07:00:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85AE81D500; Fri, 21 Jun 2019 07:00:32 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1D4EF1D4FF; Fri, 21 Jun 2019 07:00:30 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 22:00:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,399,1557212400"; d="scan'208";a="160881242" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.186]) by fmsmga008.fm.intel.com with ESMTP; 20 Jun 2019 22:00:27 -0700 Date: Fri, 21 Jun 2019 19:42:24 +0800 From: Ye Xiaolong To: Andy Pei Cc: dev@dpdk.org, helin.zhang@intel.com, stable@dpdk.org, roy.fan.zhang@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, ferruh.yigit@intel.com, rosen.xu@intel.com Message-ID: <20190621114224.GA42981@intel.com> References: <1561091696-213124-1-git-send-email-andy.pei@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1561091696-213124-1-git-send-email-andy.pei@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix core dumped when setting txq or rxq to 0 in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/21, Andy Pei wrote: >Testpmd stucked and core dumped >when set invalid VF queue number. >This patch fix this issue. It's better to wrap the commit message within 72 characters. Perhaps something like: Testpmd would stuck and result in core dump when user specifies an invalid VF queue number. This patch fixes this issue. What do you think? > >Fixes: d6b19729093e ("i40evf: support configurable crc stripping") >Cc: helin.zhang@intel.com >Cc: stable@dpdk.org > >Signed-off-by: Andy Pei >--- >Cc: roy.fan.zhang@intel.com >Cc: qi.z.zhang@intel.com >Cc: jingjing.wu@intel.com >Cc: beilei.xing@intel.com >Cc: ferruh.yigit@intel.com >Cc: rosen.xu@intel.com > > drivers/net/i40e/i40e_ethdev_vf.c | 35 ++++++++++++++++++++++++++++------- > 1 file changed, 28 insertions(+), 7 deletions(-) > >diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c >index 63dbe14..7096cc5 100644 >--- a/drivers/net/i40e/i40e_ethdev_vf.c >+++ b/drivers/net/i40e/i40e_ethdev_vf.c >@@ -573,7 +573,7 @@ struct rte_i40evf_xstats_name_off { > { > txq_info->vsi_id = vsi_id; > txq_info->queue_id = queue_id; >- if (queue_id < nb_txq) { >+ if ((queue_id < nb_txq) && txq) { > txq_info->ring_len = txq->nb_tx_desc; > txq_info->dma_ring_addr = txq->tx_ring_phys_addr; > } >@@ -590,7 +590,7 @@ struct rte_i40evf_xstats_name_off { > rxq_info->vsi_id = vsi_id; > rxq_info->queue_id = queue_id; > rxq_info->max_pkt_size = max_pkt_size; >- if (queue_id < nb_rxq) { >+ if ((queue_id < nb_rxq) && rxq) { > rxq_info->ring_len = rxq->nb_rx_desc; > rxq_info->dma_ring_addr = rxq->rx_ring_phys_addr; > rxq_info->databuffer_size = >@@ -622,11 +622,32 @@ struct rte_i40evf_xstats_name_off { > vc_vqci->num_queue_pairs = nb_qp; > > for (i = 0, vc_qpi = vc_vqci->qpair; i < nb_qp; i++, vc_qpi++) { >- i40evf_fill_virtchnl_vsi_txq_info(&vc_qpi->txq, >- vc_vqci->vsi_id, i, dev->data->nb_tx_queues, txq[i]); >- i40evf_fill_virtchnl_vsi_rxq_info(&vc_qpi->rxq, >- vc_vqci->vsi_id, i, dev->data->nb_rx_queues, >- vf->max_pkt_len, rxq[i]); >+ if (!txq) >+ i40evf_fill_virtchnl_vsi_txq_info(&vc_qpi->txq, >+ vc_vqci->vsi_id, >+ i, >+ dev->data->nb_tx_queues, >+ NULL); >+ else >+ i40evf_fill_virtchnl_vsi_txq_info(&vc_qpi->txq, >+ vc_vqci->vsi_id, >+ i, >+ dev->data->nb_tx_queues, >+ txq[i]); >+ if (!rxq) >+ i40evf_fill_virtchnl_vsi_rxq_info(&vc_qpi->rxq, >+ vc_vqci->vsi_id, >+ i, >+ dev->data->nb_rx_queues, >+ vf->max_pkt_len, >+ NULL); >+ else >+ i40evf_fill_virtchnl_vsi_rxq_info(&vc_qpi->rxq, >+ vc_vqci->vsi_id, >+ i, >+ dev->data->nb_rx_queues, >+ vf->max_pkt_len, >+ rxq[i]); No need to use one line for each parameter, I think you can still use the old format. Thanks, Xiaolong > } > memset(&args, 0, sizeof(args)); > args.ops = VIRTCHNL_OP_CONFIG_VSI_QUEUES; >-- >1.8.3.1 >