From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 958B2A046B for ; Mon, 24 Jun 2019 22:45:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69F981BC8F; Mon, 24 Jun 2019 22:44:57 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id C39A31BC7D for ; Mon, 24 Jun 2019 22:44:48 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id m4so7124805pgk.0 for ; Mon, 24 Jun 2019 13:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=; b=hmBA8dHimb4tNJBmjkb8RPJREgaQyxbOmWD39IWOu+4ahr2fLqcQQ0b0Eiw6GGAQMj sb4VPW3dNmjcJ1wkQPzrMUAsIv/IDb7NjAORirSNgEfwuVkeoHqdBNDwVbxqg4dau9l+ mzYMsZith9KJycKEq05aDA8vdfk1xXyA0XX+9KvHFHdnMOB5+Zc8rYJmutCOBnJT9IlS /VgV9lKXAy13cgU0WI6PV0CUpFLIn6KwAGjuSejXaOV5L22lkfjfrCneEXSuUscV2ufd sBh9U9DMrsIXBOcu5SscEcGCiFkOuM+J7QXDsEuDE4H1MuLbQgR36WyoG6nkNVqQW2/r 1GNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=; b=VOORtOzrS1a7EpuDuKhlWKyHBSa5yy8nSrBD6ixvqPpOeG0tN5DL2k3Ladk59Lgy2B az2XWpP009qpE+RrltYbtu5uVqyx+W+rCr37KDNHu8hMYMEnlamUcDrUIFtEs10kCScN yu+9hVgZw8RWua8VMNUefQhrHAdlBzfQNDLpkJ15KmDaYe1YV1h8ZyT+3+gvYlb+sAi+ ezar6udvolE95lj0KurlzuhQ7UOeuWPjsbDKDqtTpOHduoPOErDfeHBcHewzY8MbdVy9 FL6h2kGDgTB+4wcgIvfxXGNG/v3hMTOgLai+iQYUL3nuPpOr9ejDlcWQO0BlKdcNyGFR JxcA== X-Gm-Message-State: APjAAAXxwIoHBImPoYc/F9yoQKmD1DyQ0FvT2v/x19vRFRvMi92mimvv pp00zKYP9LcS1fH8jcZawTcAaI7UNQ4= X-Google-Smtp-Source: APXvYqzzmXlnGDHTEFf1FgTbD4rzdbBYCP6kF5+B6b1sE8ax4tLh0x8gK6JzPpPyWwqDfVIX4Po2Ng== X-Received: by 2002:a17:90a:9291:: with SMTP id n17mr26557795pjo.66.1561409087615; Mon, 24 Jun 2019 13:44:47 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q144sm22061498pfc.103.2019.06.24.13.44.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 13:44:46 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Date: Mon, 24 Jun 2019 13:44:31 -0700 Message-Id: <20190624204435.29452-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190624204435.29452-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190624204435.29452-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 8edc7e217b25..feb35a33c94b 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -81,11 +81,10 @@ struct rte_ether_addr { static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, const struct rte_ether_addr *ea2) { - int i; - for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) - if (ea1->addr_bytes[i] != ea2->addr_bytes[i]) - return 0; - return 1; + const unaligned_uint16_t *w1 = (const uint16_t *)ea1; + const unaligned_uint16_t *w2 = (const uint16_t *)ea2; + + return ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0; } /** @@ -100,11 +99,9 @@ static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, */ static inline int rte_is_zero_ether_addr(const struct rte_ether_addr *ea) { - int i; - for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) - if (ea->addr_bytes[i] != 0x00) - return 0; - return 1; + const unaligned_uint16_t *w = (const uint16_t *)ea; + + return (w[0] | w[1] | w[2]) == 0; } /** -- 2.20.1