From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52DBFA046B for ; Thu, 27 Jun 2019 17:25:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C02EF20BD; Thu, 27 Jun 2019 17:25:01 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id BF84523D for ; Thu, 27 Jun 2019 17:24:59 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id r1so1389110pfq.12 for ; Thu, 27 Jun 2019 08:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2xKv8UiLS4iZeMvLR79KOMVyYZkBaObg3J9I6vYgZMo=; b=dt04qrZOlw98OgI8qDXPpzsJRmVzujgB1dPsbBLc+Zy09gLEt/wBKBXLJqGQ5hFFIt n7vwDSi1ZJVm/8Mll8kINVZdJcUdyuwsT5TVL/AZ7ryG9UmUzxwgev5rmdWOjG4+bD/f 4NfHJnQazESy9fvM45gLAL878stDHDRtra44BR+vY4KEpOnC3u59H0ZSPbURj0sf4v/3 npgwaqQb7WHa8HnlboZdTK6UFiQyEVMAlzfHpkebFSSIZY7eUgfpEvUmGTkLFt8pz4/n UK98UH+paNYRwAMLiIzFFhdUQ8yHwqeDrppOQd8PMyGSWuOC9jWdshz2yx4cdGcWBTcA +Nyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2xKv8UiLS4iZeMvLR79KOMVyYZkBaObg3J9I6vYgZMo=; b=P2v9UWFz8P94gC70QhiLA8++oGXVWqjK7VrMIgHlgb33x296aDKgVnyc5lY8sGs5IB 2bBgLjfhUOXAbjG0qO5bm0pnL96NibX9FoGFjfe/6s0h54dYVQCFExVoV0xx4QhtDI7G oKTmGIPrVbWukqwJdK0jYii06xZKpjchVI3C9sNhPJFiAc6EweqauTlVAjeoc9w8W+mB uZc5JcbjEvDI2sczIhx44Z9lj9Mpf91+LeQxMv++kDH02Nus/n9bneuNeNv+XBQtrWyZ eg4lmutaVfyx3/JP/Duyu4OI/y5rbDp+o/KwECtEOKQWWG8HnQpzVPWARLXBtFvQDBXG mrEw== X-Gm-Message-State: APjAAAUHhkPqGxL8LJDIkNoqFvyLhr5l6zPRjENwsqpwU939yGLiudbc ltaC7doDVB44DOo5Smcz25nXAQ== X-Google-Smtp-Source: APXvYqwyUBUmgo5hREKXfQgGrT67ijkqBAHX3KczfAS7ChwU2l6xe1inbulZEgetCVAqvF6SdZ2HaA== X-Received: by 2002:a63:ea0a:: with SMTP id c10mr4459704pgi.426.1561649098813; Thu, 27 Jun 2019 08:24:58 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m6sm3019466pgr.18.2019.06.27.08.24.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 08:24:58 -0700 (PDT) Date: Thu, 27 Jun 2019 08:24:51 -0700 From: Stephen Hemminger To: Ruifeng Wang Cc: bruce.richardson@intel.com, vladimir.medvedkin@intel.com, dev@dpdk.org, honnappa.nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com Message-ID: <20190627082451.56719392@hermes.lan> In-Reply-To: <20190627093751.7746-1-ruifeng.wang@arm.com> References: <20190627093751.7746-1-ruifeng.wang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 27 Jun 2019 17:37:49 +0800 Ruifeng Wang wrote: > Tests showed that the function inlining caused performance drop > on some x86 platforms with the memory ordering patches applied. > By force no-inline functions, the performance was better than > before on x86 and no impact to arm64 platforms. > > Suggested-by: Medvedkin Vladimir > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu { Do you actually need to force noinline or is just taking of inline enough? In general, letting compiler decide is often best practice.