From: Stephen Hemminger <stephen@networkplumber.org>
To: Ivan Malov <ivan.malov@oktetlabs.ru>
Cc: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net: fix the way how L4 checksum choice is tested
Date: Thu, 27 Jun 2019 17:10:40 -0700 [thread overview]
Message-ID: <20190627171040.486aa756@hermes.lan> (raw)
In-Reply-To: <20190627215202.794-1-ivan.malov@oktetlabs.ru>
On Fri, 28 Jun 2019 00:52:02 +0300
Ivan Malov <ivan.malov@oktetlabs.ru> wrote:
> + /*
> + * Initialise ipv4_hdr beforehand to mute false positive
> + * compiler warnings about this variable being possibly used
> + * uninitialised in L4 parsing branches below albeit it is clearly
> + * initialised in IPv4 parsing branch prior L4-related code.
> + */
Really, keep the verbosity in the commit log not the code.
One line commit is enough.
next prev parent reply other threads:[~2019-06-28 0:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 17:33 [dpdk-dev] [PATCH] " Ivan Malov
2019-06-24 11:52 ` Ananyev, Konstantin
2019-06-24 12:01 ` Ananyev, Konstantin
2019-06-24 12:16 ` Andrew Rybchenko
2019-06-27 13:26 ` Ananyev, Konstantin
2019-06-27 21:52 ` [dpdk-dev] [PATCH v2] " Ivan Malov
2019-06-28 0:10 ` Stephen Hemminger [this message]
2019-06-28 3:13 ` [dpdk-dev] [PATCH v3] " Ivan Malov
2019-06-28 4:26 ` Stephen Hemminger
2019-06-28 10:47 ` Ananyev, Konstantin
2019-06-28 16:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627171040.486aa756@hermes.lan \
--to=stephen@networkplumber.org \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).