From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22045A046B for ; Fri, 28 Jun 2019 02:10:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86A07F04; Fri, 28 Jun 2019 02:10:50 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 232F7F04 for ; Fri, 28 Jun 2019 02:10:48 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id 9so1386130ple.5 for ; Thu, 27 Jun 2019 17:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jJ7M/KRfwabjI6RtXL0Fx2bK3yDHDZmZVU/nk9Ce49I=; b=TjDsdoWEjhSdNh5FZNQiwDqm17kJdBWFHS5qEGwG6UwRUbtLuWugKNZkcRjGCUXzXX wXnPCgaycgdJzZnOZN+lAnphi2dTaplptMcaIUhlS5TcCdOfYwbJpe3WkscufNB4nTWH CFmXu4RKjQQiBVk7xzwmGAjA23IvYOcuUorCu8y9uUxyv17kkVhk5fRWe+EoGlJ+taW6 U2PHil/idJy47K7Yp2z6vXV8sk4byNoank5bc/LhsK4kwvLb9tdgn36Y4Z99uxpXCtnW /l1KsGFWOJWj586tAZUjYSiOmB9z0GyF5a0o8d7WVTgCOgG5PHzB7KiIQttzKQ+eBNV8 /H3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jJ7M/KRfwabjI6RtXL0Fx2bK3yDHDZmZVU/nk9Ce49I=; b=H8BOCmvk9QAfH600X9Sopuo0/HN8DDJq0kz7YWOIq3CjQKXJAstpZGj1MV3u5dwikH AqmAi7XQoDe3wCsXZeEuJyoHdKYuTaK+d293ccJMd9eYDWxRvLU7IUfG/tBnoy7xslcP 7bdIDVyrqSjot38RsBI+BHjkG0MaCT/r7ySbgcQMs0YbI3Y9NXUCflBDbx7xX4vUVE3T iqIgW0+W+r4/M+dDxbhWFewzBOtK2Ew5rJPkmx+96YbWASpCcaOyRAKlPs/gKDZjgmTG VqU2+WJZiG4oXX9qMNjzY58i05a2BVTacYNHVszf6F2hGzvl/SrWAG9qLCxhmpxr2nR9 CRdw== X-Gm-Message-State: APjAAAVaUU97+BQCRdEBKTWWe2yEFN5nAirfv9pCxSKMfebC1YUqMUqf /dQS7QqMEZwJWjC6v8hFZKHTgg== X-Google-Smtp-Source: APXvYqxeMB+B8X0Nkb/ZMWZk1J9Sch08qkcysI+uQzGfUB70qExTnYrNQsrfXXXcUY21/sRWTT++2w== X-Received: by 2002:a17:902:1003:: with SMTP id b3mr7983218pla.172.1561680647709; Thu, 27 Jun 2019 17:10:47 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f7sm224494pfd.43.2019.06.27.17.10.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 17:10:47 -0700 (PDT) Date: Thu, 27 Jun 2019 17:10:40 -0700 From: Stephen Hemminger To: Ivan Malov Cc: Olivier Matz , dev@dpdk.org, "Ananyev, Konstantin" , Andrew Rybchenko , Tomasz Kulasek , stable@dpdk.org Message-ID: <20190627171040.486aa756@hermes.lan> In-Reply-To: <20190627215202.794-1-ivan.malov@oktetlabs.ru> References: <20190529173337.31157-1-ivan.malov@oktetlabs.ru> <20190627215202.794-1-ivan.malov@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net: fix the way how L4 checksum choice is tested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 28 Jun 2019 00:52:02 +0300 Ivan Malov wrote: > + /* > + * Initialise ipv4_hdr beforehand to mute false positive > + * compiler warnings about this variable being possibly used > + * uninitialised in L4 parsing branches below albeit it is clearly > + * initialised in IPv4 parsing branch prior L4-related code. > + */ Really, keep the verbosity in the commit log not the code. One line commit is enough.