From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00EA0A046B for ; Fri, 28 Jun 2019 03:54:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 796382AA0; Fri, 28 Jun 2019 03:54:10 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 1D7DA1E2F for ; Fri, 28 Jun 2019 03:54:08 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 18:54:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,425,1557212400"; d="scan'208";a="313995784" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.186]) by orsmga004.jf.intel.com with ESMTP; 27 Jun 2019 18:54:05 -0700 Date: Fri, 28 Jun 2019 16:35:39 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: John McNamara , Marko Kovacevic , Qi Zhang , Karlsson Magnus , Topel Bjorn , yuan.peng@intel.com, dev@dpdk.org Message-ID: <20190628083539.GA90458@intel.com> References: <20190617142303.85240-1-xiaolong.ye@intel.com> <20190621131915.46662-1-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] net/af_xdp: support need wakeup feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh On 06/27, Ferruh Yigit wrote: >On 6/21/2019 2:19 PM, Xiaolong Ye wrote: >> This patch enables need_wakeup flag for Tx and fill rings, when this flag >> is set by the driver, it means that the userspace application has to >> explicitly wake up the kernel Rx or kernel Tx processing by issuing a >> syscall. Poll() can wake up both and sendto() or its alternatives will wake >> up Tx processing only. >> >> This feature is to provide efficient support for case that application and >> driver executing on the same core. >> >> Signed-off-by: Xiaolong Ye >> --- >> v3 changes: >> >> 1. add introduction in 19.08 release note >> >> v2 changes: >> >> 1. remove need_wakeup devarg to make need_wakeup feature enabled >> unconditionally. >> 2. add conditional compilation directive to avoid breaking build with >> kernel which doesn't support need_wakeup feature yet. >> >> Note: >> >> Original busy poll feature has morphed into need_wakeup flag in >> kernel side, the main purpose is the same, that is to support both >> application and driver executing on the same core efficiently. >> doc/guides/rel_notes/release_19_08.rst | 2 ++ >> drivers/net/af_xdp/rte_eth_af_xdp.c | 41 +++++++++++++++++++------- > >Hi Xiaolong, > >Can you please document this feature in af_xdp documentation? And if there >specific kernel version requirement for this, can you please add this >information too? Got it, will do in next version. Thanks, Xiaolong >