Re: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop functions

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Jun 27, 2019 at 05:37:33PM +0100, Pattan, Reshma wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> > Sent: Thursday, June 27, 2019 11:41 AM
> > To: dev@dpdk.org
> > Cc: thomas@monjalon.net; jerinj@marvell.com; Richardson, Bruce
> > <bruce.richardson@intel.com>
> > Subject: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop
> > functions
> 
> <snip>
> 
> > +int ioat_rawdev_test(uint16_t dev_id);
> > +
> >  static int
> >  ioat_rawdev_create(const char *name, struct rte_pci_device *dev)  {
> >  	static const struct rte_rawdev_ops ioat_rawdev_ops = {
> > +			.dev_configure = ioat_dev_configure,
> > +			.dev_start = ioat_dev_start,
> > +			.dev_stop = ioat_dev_stop,
> >  			.dev_info_get = ioat_dev_info_get,
> > +			.dev_selftest = ioat_rawdev_test,
> 
> Build fail for  ./devtools/test-build.sh x86_64-native-linux-gcc+next+shared
> /drivers/raw/ioat/ioat_rawdev.c: In function 'ioat_rawdev_create':
> drivers/raw/ioat/ioat_rawdev.c:163:20: error: initialization of 'int (*)(void)' from incompatible pointer type 'int (*)(uint16_t)' {aka 'int (*)(short unsigned int)'} [-Werror=incompatible-pointer-types]
>   163 |    .dev_selftest = ioat_rawdev_test,
> 

Apologies, I forgot to put in the cover letter that this depends upon the
rawdev patchset I previously upstreamed: 

http://patches.dpdk.org/project/dpdk/list/?series=5120