From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 01703A0487
for <public@inbox.dpdk.org>; Sun, 30 Jun 2019 22:28:04 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 814481B964;
Sun, 30 Jun 2019 22:28:03 +0200 (CEST)
Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com
[209.85.214.181]) by dpdk.org (Postfix) with ESMTP id D7C162AB
for <dev@dpdk.org>; Sun, 30 Jun 2019 22:28:01 +0200 (CEST)
Received: by mail-pl1-f181.google.com with SMTP id t7so6158912plr.11
for <dev@dpdk.org>; Sun, 30 Jun 2019 13:28:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=D7X+NFlRaZ5+OPQODM2dWPPO4gsfA3jDT3/NR4w3bfY=;
b=O/lLCWmEILEEnX8kTHqJGB7VGQWZ5DHTOJgM9FuGDqEOY9JRgJNYGOyzyhJ+a84as3
SgifVayB5RDBGVoBNC1eXF4aJgm1VSYwMfuF9n0uWudgvQzDkSfEN3RnTUJWSUuOeuFd
xfDSYOCfrUtd8Nq1b9CD5w0cvIOESSCa3GKIDX9+9idEhBNRjOLyZjeoVDfsZw3m9juc
5eTq8SiVFrQr/rR1jhsz0PWS+yvg/uxfllGO6R4hWtR6gx4cycUANYQ5oJGcTqna858l
rHySgDHXh/S1/M0sazZ43r4M91Zed+SEtFWTlCBvTHeWQKGmyAzl9WZ0zz3Lg9EeGUET
AZQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=D7X+NFlRaZ5+OPQODM2dWPPO4gsfA3jDT3/NR4w3bfY=;
b=o6rm1wFaCiiN6E8zDHfETfHx0CKZ5bi+lEOKgyGPQ+2fcGxPHzRhg9r3QsdmJi8R/R
684/R6C8xGqz9ULYcBn0ECT07vcQtIcmLJjyO9nh9ZkLH1Us16+IndnUdyJNnxCvXo1e
u/B9/FoupcdCtV8OI4Fb72vfFh5HmxZVcNU9UmDOt2JqrtOhJ8LIQ3EXRnG/f/oug+ub
4PCz5QbnPhsbyt1IkLYiBQ11PJdsn5pdjWxXiCWgFttP7JHGRm/iCICR+dzI6xQXR/1c
s9y4bBRF6Uh02/C0m2D+ekTcaB4+e4Dq+94au3uBMvzXxySQv5VSJmKaKnoT5FGQmdqJ
8nEQ==
X-Gm-Message-State: APjAAAVDoW0HZdUgH6A4uFiZC0GeDOY9iRowE3VUFQsi6wAJJai8zmFd
RWXqg2WLWSEA/T5ENEoKG4sZTA==
X-Google-Smtp-Source: APXvYqzo2p1K+dJb6f29harxxQLb0Eigp/4C+TsCwa6MNHxiOmfsDorqjY9jjI1ZtRyn7v2hVMraqQ==
X-Received: by 2002:a17:902:7791:: with SMTP id
o17mr23465426pll.162.1561926480833;
Sun, 30 Jun 2019 13:28:00 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id 1sm8868977pfe.102.2019.06.30.13.27.59
(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
Sun, 30 Jun 2019 13:28:00 -0700 (PDT)
Date: Sun, 30 Jun 2019 13:27:53 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, thomas@monjalon.net, jerinj@marvell.com,
hemant.agrawal@nxp.com, bruce.richardson@intel.com,
chaozhu@linux.vnet.ibm.com, Honnappa.Nagarahalli@arm.com, nd@arm.com
Message-ID: <20190630132753.3f8139f0@hermes.lan>
In-Reply-To: <1561911676-37718-2-git-send-email-gavin.hu@arm.com>
References: <1561911676-37718-1-git-send-email-gavin.hu@arm.com>
<1561911676-37718-2-git-send-email-gavin.hu@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC 1/5] eal: add the APIs to wait until equal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Mon, 1 Jul 2019 00:21:12 +0800
Gavin Hu <gavin.hu@arm.com> wrote:
> +#ifdef RTE_USE_WFE
> +#define rte_wait_until_equal_relaxed(addr, expected) do {\
> + typeof(*addr) tmp; \
> + if (__builtin_constant_p((expected))) \
> + do { \
> + if (sizeof(*(addr)) == 16)\
> + asm volatile( \
> + "sevl\n" \
> + "1: wfe\n" \
> + "ldxrh %w0, %1\n" \
> + "cmp %w0, %w2\n" \
> + "bne 1b\n" \
> + : "=&r"(tmp) \
> + : "Q"(*addr), "i"(expected) \
> + : "cc", "memory"); \
> + else if (sizeof(*(addr)) == 32)\
> + asm volatile( \
> + "sevl\n" \
> + "1: wfe\n" \
> + "ldxr %w0, %1\n" \
> + "cmp %w0, %w2\n" \
> + "bne 1b\n" \
> + : "=&r"(tmp) \
> + : "Q"(*addr), "i"(expected) \
> + : "cc", "memory"); \
> + else if (sizeof(*(addr)) == 64)\
> + asm volatile( \
> + "sevl\n" \
> + "1: wfe\n" \
> + "ldxr %x0, %1\n" \
> + "cmp %x0, %x2\n" \
> + "bne 1b\n" \
> + : "=&r" (tmp) \
> + : "Q"(*addr), "i"(expected) \
> + : "cc", "memory"); \
> + } while (0); \
> + else \
> + do { \
> + if (sizeof(*(addr)) == 16)\
> + asm volatile( \
> + "sevl\n" \
> + "1: wfe\n" \
> + "ldxrh %w0, %1\n" \
> + "cmp %w0, %w2\n" \
> + "bne 1b\n" \
> + : "=&r"(tmp) \
> + : "Q"(*addr), "r"(expected) \
> + : "cc", "memory"); \
> + else if (sizeof(*(addr)) == 32)\
> + asm volatile( \
> + "sevl\n" \
> + "1: wfe\n" \
> + "ldxr %w0, %1\n" \
> + "cmp %w0, %w2\n" \
> + "bne 1b\n" \
> + : "=&r"(tmp) \
> + : "Q"(*addr), "r"(expected) \
> + : "cc", "memory"); \
> + else if (sizeof(*(addr)) == 64)\
> + asm volatile( \
> + "sevl\n" \
> + "1: wfe\n" \
> + "ldxr %x0, %1\n" \
> + "cmp %x0, %x2\n" \
> + "bne 1b\n" \
> + : "=&r" (tmp) \
> + : "Q"(*addr), "r"(expected) \
> + : "cc", "memory"); \
> + } while (0); \
> +} while (0)
That is a hot mess.
Macro's are harder to maintain and offer no benefit over inline functions.