From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2E7CA0487 for ; Mon, 1 Jul 2019 16:59:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 004961B9D7; Mon, 1 Jul 2019 16:59:40 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 82DAA1B9D6 for ; Mon, 1 Jul 2019 16:59:39 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id q4so4699267pgj.8 for ; Mon, 01 Jul 2019 07:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y/TkyWgWr2ld0N66pQ8iEg6TR+AT+fNl6GHAO5sQ1J8=; b=w6t2kccShYNlS6cqJ9YydFVt4K4dPEqHbuP/vsneR7ZPi7SmOtgbDJ8xx4PZEZHIB0 ggTAzBRyAnIZ0qXnwhWmAMiC967ZBdqlraRz1YUJ/HLz6v/dupQXuQvCBBETC/yf3srf 4kDUcvFDeLpNx3efnwA+f8PCxSm+4ctXA7jgeuZGT1kqT07yTkofbBlhONEGgoHtAzLZ hLmlhI6EzZOQKuxHQP7cVaF9K0L6sGeVq6vuZYcMUkMmIVPvM/biAn8C1xZ0PS2c1sL0 9Gg+yMY5RAjxAh9tCTSya8a8QM8ASr2L+9wyuQqBaIYexVPKCDTMpDcVavQN77njJd3J J9qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y/TkyWgWr2ld0N66pQ8iEg6TR+AT+fNl6GHAO5sQ1J8=; b=sgRT9e1qD/OnwRqsb6wRbLF9NH0buKaM83QL9JZ4AiinSeR1nJhx4CkwJ4LFmn3fH9 LszKLJe89bd37Fybe7xOzv4guqTrgBc57zYHkrHUFBV1GE1DZIyTtNsqAoD0e4M5ZAYD ktxZbqzDx6uqeDjAX5SLjQbEoqFZIBB330iJ0l8Ry9idQqjKDgDJbHLBfwtETP41A3Gd KwGtKVyfeWd7DLlmfYB9Cm3QwoGPiVXPzRzOLia300qJ6yJE0gHJowzschQubtkQ/Sqh 1fynehRhkcrn/39jfjOUXclNdIF2G6M8aceTu6ZrpcOIRPDFgyGvW0nG3BvOBNkc0yGV wTNw== X-Gm-Message-State: APjAAAVfJxD6T1SdVF/IX0so+blrzidWkLqolfSpgSNnUphaFzIUTnek bRXB0y61Jq844erRlcY8AAHUHA== X-Google-Smtp-Source: APXvYqy5U4EEKXhTO/QjNjT1gPzaUjLAdFAaPI3KpIUmIz6MSTHIyNrPt6j9cM3m+hGWQn0EIczcRQ== X-Received: by 2002:a63:5964:: with SMTP id j36mr22985733pgm.428.1561993178353; Mon, 01 Jul 2019 07:59:38 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d12sm11103055pfd.96.2019.07.01.07.59.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 07:59:38 -0700 (PDT) Date: Mon, 1 Jul 2019 07:59:30 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: , , Stephen Hemminger Message-ID: <20190701075930.3ed1d844@hermes.lan> In-Reply-To: References: <20190626222135.11368-1-stephen@networkplumber.org> <20190626233346.4719-1-stephen@networkplumber.org> <20190626233346.4719-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: expose basic xstats for driver use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 1 Jul 2019 13:54:52 +0300 Andrew Rybchenko wrote: > On 27.06.2019 2:33, Stephen Hemminger wrote: > > Avoid duplication by having generic basic xstats available > > for use by drivers. A later patch uses this for failsafe > > driver. > > > > Signed-off-by: Stephen Hemminger > > [...] > > > > diff --git a/lib/librte_ethdev/rte_ethdev_core.h b/lib/librte_ethdev/rte_ethdev_core.h > > index 2922d5b7cc95..91ce1880d1c6 100644 > > --- a/lib/librte_ethdev/rte_ethdev_core.h > > +++ b/lib/librte_ethdev/rte_ethdev_core.h > > @@ -517,6 +517,20 @@ struct eth_dev_ops { > > /**< Test if a port supports specific mempool ops */ > > }; > > > > +/** > > + * @internal > > + * Get basic stats for ethdev > > + */ > > +int __rte_experimental > > +rte_eth_basic_stats_count(struct rte_eth_dev *dev); > > + > > +int __rte_experimental > > +rte_eth_basic_stats_get_names(struct rte_eth_dev *dev, > > + struct rte_eth_xstat_name *xstats_names); > > + > > +int __rte_experimental > > +rte_eth_basic_stats_get(uint16_t port_id, struct rte_eth_xstat *xstats); > > + > > /** > > * @internal > > * Structure used to hold information about the callbacks to be called for a > > It conflicts with __rte_experimenal placing patch which is on the > mailing list. > Also I've expected to see these functions in rte_ethdev_driver.h to > avoid inclusion in rte_ethdev.h. As I understand these functions are for > rte_ethdev and drivers only. Yes. Will change in V3