DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>, dev <dev@dpdk.org>,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag
Date: Mon, 1 Jul 2019 10:39:49 +0200	[thread overview]
Message-ID: <20190701083949.GC3911@6wind.com> (raw)
In-Reply-To: <CAJFAV8wxyys8DWKkM80sFUkKaJ9dA0d5dNKrNv+g=x__68ys9Q@mail.gmail.com>

On Fri, Jun 28, 2019 at 06:23:19PM +0200, David Marchand wrote:
> On Fri, Jun 28, 2019 at 5:57 PM Adrien Mazarguil <adrien.mazarguil@6wind.com>
> wrote:
> 
> > Its presence on the function prototype in the header file is enough.
> >
> > Fixes: 5f4ed3f05849 ("eal: introduce random generator with upper bound")
> > Cc: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > ---
> >  lib/librte_eal/common/rte_random.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/common/rte_random.c
> > b/lib/librte_eal/common/rte_random.c
> > index 3d9b9b7d8..f85119048 100644
> > --- a/lib/librte_eal/common/rte_random.c
> > +++ b/lib/librte_eal/common/rte_random.c
> > @@ -137,7 +137,7 @@ rte_rand(void)
> >         return __rte_rand_lfsr258(state);
> >  }
> >
> > -uint64_t __rte_experimental
> > +uint64_t
> >  rte_rand_max(uint64_t upper_bound)
> >  {
> >         struct rte_rand_state *state;
> > --
> > 2.11.0
> >
> 
> I had mentionned to Thomas I would do an extra pass, thanks for already
> catching this one.
> Do you mind if I squash this in my series ?

No problem, this series was tailored for this exact purpose, thanks for v2!

-- 
Adrien Mazarguil
6WIND

  reply	other threads:[~2019-07-01  8:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 15:56 [dpdk-dev] [PATCH 0/2] Fix remaining issues with __rte_experimental Adrien Mazarguil
2019-06-28 15:56 ` [dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag Adrien Mazarguil
2019-06-28 16:05   ` Stephen Hemminger
2019-06-28 16:23   ` David Marchand
2019-07-01  8:39     ` Adrien Mazarguil [this message]
2019-06-28 15:56 ` [dpdk-dev] [PATCH 2/2] Fix __rte_experimental clutter Adrien Mazarguil
2019-06-28 19:22   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190701083949.GC3911@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).