From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A953A0487 for ; Mon, 1 Jul 2019 22:38:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F40401B4B6; Mon, 1 Jul 2019 22:38:16 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 673EE5F11 for ; Mon, 1 Jul 2019 22:38:15 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 13:38:14 -0700 X-IronPort-AV: E=Sophos;i="5.63,440,1557212400"; d="scan'208";a="157406137" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.62]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 13:38:11 -0700 Date: Mon, 1 Jul 2019 21:38:07 +0100 From: Bruce Richardson To: "Chautru, Nicolas" Cc: Thomas Monjalon , Akhil Goyal , "dev@dpdk.org" , "Yigit, Ferruh" , "Mokhtar, Amr" Message-ID: <20190701203807.GA393@bricha3-MOBL.ger.corp.intel.com> References: <1561136352-32198-2-git-send-email-nicolas.chautru@intel.com> <1183128033837D43A851F70F33ED5C575C1CA1FD@FMSMSX109.amr.corp.intel.com> <8053064.aIbUgzIKpn@xps> <1183128033837D43A851F70F33ED5C575C1CA644@FMSMSX109.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1183128033837D43A851F70F33ED5C575C1CA644@FMSMSX109.amr.corp.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v4 10/10] doc: announce bbdev changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 01, 2019 at 09:27:56PM +0100, Chautru, Nicolas wrote: > > >-----Original Message----- > >From: Thomas Monjalon [mailto:thomas@monjalon.net] > >Sent: Monday, July 1, 2019 12:18 PM > >To: Chautru, Nicolas > >Cc: Akhil Goyal ; dev@dpdk.org; Yigit, Ferruh ; Mokhtar, Amr > >Subject: Re: [PATCH v4 10/10] doc: announce bbdev changes > > > >01/07/2019 20:14, Chautru, Nicolas: > >> > >> >One more thing, if there is a change in ABI, should you also increment the bbdev ABI version? > >> > >> The bbdev ABI is still marked as __rte_experimental hence I don't believe we have yet to increment it. > > > >ABI version and experimental state are two different things. > >I think we should upgrade the version even for experimental libraries. > > Thanks Thomas. > > Bruce, Ferruh can you comment whether bumping ABI version is required for __rte_experimental API? Arguably the documentation may be interpreted either way : https://doc.dpdk.org/guides-18.08/contributing/versioning.html > > In the specific case of bbdev change in that serie, note that only new operations (for 5GNR signal processing) and related symbols are being added. > Previous releases included BBDEV API changes without updating ABI version number ( librte_bbdev.so.1). > > Thanks for letting me know, in both cases we may make it more explicit on the versioning page. > Nic I think there may be some misunderstanding here, so long as no existing APIs are changed or removed, we don't bump the ABI version. /Bruce