From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9245AA0487 for ; Tue, 2 Jul 2019 18:51:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 619221B9D0; Tue, 2 Jul 2019 18:50:38 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 4A4691B9B9 for ; Tue, 2 Jul 2019 18:50:31 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id w10so7960792pgj.7 for ; Tue, 02 Jul 2019 09:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=; b=UTnZLWi+Pk9TmMj6cTXH9dUugLhUesc+BFjdMiEAMulvGD+bgyoAzdrtI20u83fPHw zUmSkgf4Sl2ybaHh0qYMpkUcN0qOYTe+3WUFPsSo6rDMcjv5KO31YH8QCOmd8UTHJ32t hq2Vp7/FHGK8715x1VpFbH6FSS0yqbe9A3+QnnxHZRKlSReYos6+nmZ7oAUBSGC2DX3n WI2JWO7ORmVAk43SLTcQrfY0t5YKvjKCUsNmzAA9TVZTzMN2abWERWwcP0ZJiwflA2rE V3YabIwt5M0YL36LCVXXMMGgzisWI/UXqwIEeSfLE851Yip2T925IDMTb7KvCJJio2si qSLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=; b=WoiInsVp/qflBI4TWWHh3NTR92Pg8vFSnQYWbdc0tg+xWvzBXReO8nlMLxkdOuvWki 2H/quOi5IXfYancKaSLtIjSC9XLEF1nI9dknnA5y1gxlc7bmxCzGObYGHmVL3j7iLS4R GFqa8d3HzJ/Ea9YKBT+7PBNlgeotLzpMGPJo1HR2z8eUSm8i/psXvzU/VCDfhSg3X6u3 7ZUgNz2bWsPA/RmfOKIG8dYcOl9UBrqDzNHvAxN2OyS0ewCm6w2JfOWYUdjfwIyQaaBc mUEB49fx0RQ7iSIXqxByHetVYosoaDfJQElaMxXEGCVHl/xkjanxm2+LQRndDE3MlMDJ 8d/Q== X-Gm-Message-State: APjAAAVBwyU+wwtBSq1o1FirSYVdg4TGpohTVj7/dCuMLqhswQuFDC8Q shVS3u2rWidbUQm2Jt/NLwr3zxM8 X-Google-Smtp-Source: APXvYqy1Z6YZLrsbNdb3w3c+f13YGUa41H3g09zpC2AUykBBXoWZEhuxln58uzpXdZMJQhcySWqp2A== X-Received: by 2002:a17:90a:2305:: with SMTP id f5mr7011508pje.128.1562086230209; Tue, 02 Jul 2019 09:50:30 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h62sm14340230pgc.54.2019.07.02.09.50.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 09:50:29 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Date: Tue, 2 Jul 2019 09:50:13 -0700 Message-Id: <20190702165017.3802-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190702165017.3802-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190702165017.3802-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 4/8] net/ether: use bitops to speedup comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 8edc7e217b25..feb35a33c94b 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -81,11 +81,10 @@ struct rte_ether_addr { static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, const struct rte_ether_addr *ea2) { - int i; - for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) - if (ea1->addr_bytes[i] != ea2->addr_bytes[i]) - return 0; - return 1; + const unaligned_uint16_t *w1 = (const uint16_t *)ea1; + const unaligned_uint16_t *w2 = (const uint16_t *)ea2; + + return ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0; } /** @@ -100,11 +99,9 @@ static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, */ static inline int rte_is_zero_ether_addr(const struct rte_ether_addr *ea) { - int i; - for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) - if (ea->addr_bytes[i] != 0x00) - return 0; - return 1; + const unaligned_uint16_t *w = (const uint16_t *)ea; + + return (w[0] | w[1] | w[2]) == 0; } /** -- 2.20.1