From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5BA1A0487 for ; Tue, 2 Jul 2019 18:51:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6710A1B9E8; Tue, 2 Jul 2019 18:50:41 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id AA1701B9BB for ; Tue, 2 Jul 2019 18:50:32 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id q4so6480723pgj.8 for ; Tue, 02 Jul 2019 09:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5jmpHlnhidg0ShQ7XItCpgaXpVK1xXtowoDpbYktXUk=; b=Hb4G5hPL601+iGgON0aJQ289Puxc1XaaWdrLjLUAWFGvbLb2M3FMHJE2fy+6BL8pnW tKDSuAkGrwTVPa+i029qtTcrlbzaaYIIrC4ewwwwedyxafLf7RxQidV3HhEDBD1INBTu wLYLhhqd7VzimC34eKky2wXQARmw4BaqtnCkdJ2RVQpj9ZlnGuuJJc4OnWjHOrYyS0Xv Bjb9STTkI6eITuSm4cAFzDCRkjMvkWiU4i4owWIAAWpQk6gQ01NlXxn1D/13h3zMmtWZ p2oBZaKqZyo+eP/H/tUNJX7pKYi17vMrNze+bPWN+stYgx7/4J4vJNiEvU1HDRg+AGC8 uqgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5jmpHlnhidg0ShQ7XItCpgaXpVK1xXtowoDpbYktXUk=; b=HPekVUPzzk4zGJVBz6nvVfEMTS7sZAYM/ofQih4ln6d0yiGCW94VgLO8HHm0hT2+T1 SwRVk+sUfJHL2/g7rsJxUhS4t1URDQqiqO+ZhKvpNyxZ2Yaq+PDAFsyWnLcrJiVJ/fEk x0vI/VGCPmz4uIoOtiHPvjJmZEZiJu2hhAUOIUtg4UE4f6HSkJYlaZhlQ1SEQnsjvJuP FGq2kIdFSeXbaNsX/XlWPv8byfGrelew9lV/pGatwoyH+ickBo+J//22Ki+FUkX7qngH py2MK/xKw424l23VPKefqfW0V+1OComUBn/JA2oyYL8gyMCdOuH3w/sDgwxnHfht5LZ+ M9Ww== X-Gm-Message-State: APjAAAUf5Pd4zYkmyIX091buZ2q1LzzSSl5SphMDaEh8tSBF8wuTsxg5 ZqSeNRtfZqF29iU4JcWPswooDX1aWkI= X-Google-Smtp-Source: APXvYqzN+bWB7DFkytmiGWT8zlB1PbDV+2TC0kYlWmyGajBg5rAv3RhgoRdhex3sZ4yTGR/njdYlFA== X-Received: by 2002:a17:90a:30cf:: with SMTP id h73mr6807854pjb.42.1562086231629; Tue, 02 Jul 2019 09:50:31 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h62sm14340230pgc.54.2019.07.02.09.50.30 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 09:50:30 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Bruce Richardson , Stephen Hemminger , Andrew Rybchenko Date: Tue, 2 Jul 2019 09:50:14 -0700 Message-Id: <20190702165017.3802-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190702165017.3802-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190702165017.3802-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 5/8] net/ether: mark ethernet addresses as being 2-byte aligned X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Bruce Richardson When including the rte_ether.h header in applications with warnings enabled, a warning was given because of the assumption of 2-byte alignment of ethernet addresses when processing them. .../include/rte_ether.h:149:2: warning: converting a packed ‘const struct ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’ {aka ‘const short unsigned int’} pointer (alignment 2) may result in an unaligned pointer value [-Waddress-of-packed-member] 149 | const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea; | ^~~~~ Since ethernet addresses should always be aligned on a two-byte boundary, we can just inform the compiler of this assumption to remove the warnings and allow us to always access the addresses using 16-bit operations. Signed-off-by: Bruce Richardson Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index feb35a33c94b..d7b76ddf63eb 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -58,7 +58,8 @@ extern "C" { * See http://standards.ieee.org/regauth/groupmac/tutorial.html */ struct rte_ether_addr { - uint8_t addr_bytes[RTE_ETHER_ADDR_LEN]; /**< Addr bytes in tx order */ + uint8_t addr_bytes[RTE_ETHER_ADDR_LEN] __rte_aligned(2); + /**< Addr bytes in tx order */ } __attribute__((__packed__)); #define RTE_ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */ @@ -81,8 +82,8 @@ struct rte_ether_addr { static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, const struct rte_ether_addr *ea2) { - const unaligned_uint16_t *w1 = (const uint16_t *)ea1; - const unaligned_uint16_t *w2 = (const uint16_t *)ea2; + const uint16_t *w1 = (const uint16_t *)ea1; + const uint16_t *w2 = (const uint16_t *)ea2; return ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0; } @@ -99,7 +100,7 @@ static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, */ static inline int rte_is_zero_ether_addr(const struct rte_ether_addr *ea) { - const unaligned_uint16_t *w = (const uint16_t *)ea; + const uint16_t *w = (const uint16_t *)ea; return (w[0] | w[1] | w[2]) == 0; } @@ -146,7 +147,7 @@ static inline int rte_is_multicast_ether_addr(const struct rte_ether_addr *ea) */ static inline int rte_is_broadcast_ether_addr(const struct rte_ether_addr *ea) { - const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea; + const uint16_t *ea_words = (const uint16_t *)ea; return (ea_words[0] == 0xFFFF && ea_words[1] == 0xFFFF && ea_words[2] == 0xFFFF); -- 2.20.1