From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 028F9A0487 for ; Tue, 2 Jul 2019 18:51:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D5111B9F0; Tue, 2 Jul 2019 18:50:48 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 9EE6B1B9C4 for ; Tue, 2 Jul 2019 18:50:34 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id s27so7973565pgl.2 for ; Tue, 02 Jul 2019 09:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=kxkDyd3O7n04GShfEt7XG5OhDDEwb1+vI/EH9KmKcArsQChTHA5uUQ1f3okoGT+0lo utbSA6f5sQAV2yYBH3Uqhn5iNzPBx8/zQmylZ0Vvj6hpGmyQ1XgginavIkRONO5ITZVY v4H7sULMFxVlS7FKk0WjLkdZgQCoMke/dG6BIMcEAM4TZYa92pHAKfuDEiljbGcCY3Q+ x+9qtsuDR0s8U9cT0myorfM5VWThMXLI5j+53fouF7ATQL+H0CiZmAgnG1imap+kAJiP 7JNgpsXcc+eMWxpqLwGXUmbCVxDputkwMZ0/fH0MDKWbI7Qc2LhvfFvjGdbBaGKX8gFg GXVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=gy/1coUw5yYh5r47Bb4LpOFGJrvx4tFGrg5IVptvC2C37wB8DVulDAhoPYDAoE6NKW VaO5ekBHdDfZ0Sa+j38MyYIIs+D7y7g9QFisTGmvqRdiq30nUN2vn+G7SQ8Onav3C7F4 9p71yVgwjIydnHK99riOniKOlsM5klrrCdZ61skHbLtKLPhJoZxpZHk/MeR0QcmXOaqK xnJwxEs2gDEzLU8BZXa95BA6R7Mg36s6r8e0ODQ4GxZHzkbqS3k7S7QUUB0qcUSuWRx2 0WU/OTypUj4Nk9wdHIASSmNrKhwDlHxyBVXj8TucPL3ZZkVpiVswQVJQGwunMLndfBc6 jRVg== X-Gm-Message-State: APjAAAUCWmcW8HtsLP/HBrqnTp14h6DzdATyw/IKvJdpfXVxgPjiUgsk 64D/MeBXUKFgYWQ2AxvdV8e8lnwLLMg= X-Google-Smtp-Source: APXvYqyEBPzsrgE4U5dZI2YhzRI1eWd+kJ6nsEJzHptKzdFrmnNzloVeORWnPuPpK8I0oPg+720TGw== X-Received: by 2002:a17:90b:d82:: with SMTP id bg2mr6733181pjb.87.1562086233570; Tue, 02 Jul 2019 09:50:33 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h62sm14340230pgc.54.2019.07.02.09.50.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 09:50:33 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 2 Jul 2019 09:50:16 -0700 Message-Id: <20190702165017.3802-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190702165017.3802-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190702165017.3802-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 7/8] net/bonding: use new ethernet address parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile | 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile index 1893e3cad313..26c1782554cd 100644 --- a/drivers/net/bonding/Makefile +++ b/drivers/net/bonding/Makefile @@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_pci -lrte_bus_pci LDLIBS += -lrte_bus_vdev diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build index 00374edb2a9d..6267210adf5f 100644 --- a/drivers/net/bonding/meson.build +++ b/drivers/net/bonding/meson.build @@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c 'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c') deps += 'sched' # needed for rte_bitmap.h -deps += ['ip_frag', 'cmdline'] +deps += ['ip_frag'] install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h') diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index 01bbb06c1a84..936440fb8491 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -7,9 +7,6 @@ #include #include -#include -#include - #include "rte_eth_bond.h" #include "rte_eth_bond_private.h" @@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused, return -1; /* Parse MAC */ - return cmdline_parse_etheraddr(NULL, value, extra_args, - sizeof(struct rte_ether_addr)); + return rte_ether_unformat_addr(value, extra_args); } int -- 2.20.1