From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EA278A0487
	for <public@inbox.dpdk.org>; Tue,  2 Jul 2019 22:07:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 613C11BDE0;
	Tue,  2 Jul 2019 22:07:25 +0200 (CEST)
Received: from mails1n0-route0.email.arizona.edu
 (mails1n0-route0.email.arizona.edu [128.196.130.69])
 by dpdk.org (Postfix) with ESMTP id B46A631FC
 for <dev@dpdk.org>; Tue,  2 Jul 2019 22:07:23 +0200 (CEST)
IronPort-SDR: DvIEsZ5Shj4gG0v4LJhC/+Crn3Vr0bUBK0+VDvDlnLP6DO/BlKF1pmHfICeRNMFQvey8PwHIHF
 1cSatK24/QHA==
IronPort-PHdr: =?us-ascii?q?9a23=3AB+WlhBNNLnDZrsFJcs4l6mtUPXoX/o7sNwtQ0K?=
 =?us-ascii?q?IMzox0K/z5p8bcNUDSrc9gkEXOFd2Cra4d0ayM4+u5BTNIyK3CmUhKSIZLWR?=
 =?us-ascii?q?4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBx?=
 =?us-ascii?q?rwKxd+KPjrFY7OlcS30P2594HObwlSizexfK1+IA+ooQjSucUanIRvJ6QswR?=
 =?us-ascii?q?bVv3VEfPhby3l1LlyJhRb84cmw/J9n8ytOvv8q6tBNX6bncakmVLJUFDspPX?=
 =?us-ascii?q?w7683trhnDUBCA5mAAXWUMkxpHGBbK4RfnVZrsqCT6t+592C6HPc3qSL0/RD?=
 =?us-ascii?q?qv47t3RBLulSwKLCAy/n3JhcNsjaJbuBOhqAJ5w47Ie4GeKf5ycrrAcd8GWW?=
 =?us-ascii?q?ZNW8BcXDFDDIyhdYsCF+gOPehYoYfguVUDtgeyCRWwCO/z1jNEmmP60Ksn2O?=
 =?us-ascii?q?ohCwHG2wkgEsoKvnTJqtX0O6YSXvqyzKLV0DvDb/JW0ir65YjTbxAhp/eMXL?=
 =?us-ascii?q?J0ccXLz0kgCgPFg06fqYzgJTyV1+ANv3KH4OpnUOKikmgqoBx/rDiow8cjkI?=
 =?us-ascii?q?jJhoQNx1/Z7SV23YU1Kce/SE5hbt6pFoZbuSKCN4ZuX88vR39ktDwnxrEYo5?=
 =?us-ascii?q?K2fSwHxI4nyhLHdvCKd5aE7gj+WOqPOzt1hXZodKiiixux8EWtzPD3WNOu31?=
 =?us-ascii?q?ZQtCVFl8HBtnUK1xPO9MeKUuB9/kK92TaX0ADT9/1ELVg0laXFL54hxaY9lp?=
 =?us-ascii?q?0LsUTfHy/2nV/5gLWKeUU/4OSn8f7nYrTnp5+bMY97kBvyPbozlcyiGeg4Mw?=
 =?us-ascii?q?4OUHaH+emkybHu+VP1TK9XgvEoiKXUsZTXKd4bq6KhBg9ayIcj6xKxDze819?=
 =?us-ascii?q?QYmGEKLElFeBKGjYjpJlfOIf/5DfilhFShiytkx+vcMrL7GJXNL3nCkLDnfb?=
 =?us-ascii?q?ln8UJT1hc8zc1H65JOFr4BOO7zWlP2tNHADx45Mwu0w/vnCdpnyoMRR3mPD7?=
 =?us-ascii?q?SWMKPXq1CI5+YvL/OQa48SvTb3M+Il6OL2jX8lhV8derGk3YALaH+mBvRmI1?=
 =?us-ascii?q?uWYXz3j9cHD2gKogQ/TOvwiF2BST5TY2uyX6cn6T4lEoKqF4DDRpqigLaZxi?=
 =?us-ascii?q?e0AoVWZnxaClCLCXroeZuLW+0WaCKPIs9tiDwFVbmuS48gyRGjrw76y7x7Lu?=
 =?us-ascii?q?XK/i0Ur47s1N9w5+fLjxE96SR0D9iB02GKV2x0hWQISCIo06F/ukF90EyM3r?=
 =?us-ascii?q?N+g/BCCdNT4PZJWB8gNZHA1+x6F8zyWgXZc9iUVlmmXM6rDiwpTt0swN8CeU?=
 =?us-ascii?q?F9G8+tjkOL4y3/D7ILv7CTCJ9y9bjTjFbrIMMo6WvAxKgoiBEdQsoHYXa7gK?=
 =?us-ascii?q?hu8wHVC47hnECQlqLsfqMZin2evFyfxHaD6RkLGDV7Vr/ICDVGPhPb?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2BqAABFuBtdjAVFDMBlHgEGBwaBUwk?=
 =?us-ascii?q?LAYJ0DFIyKIgXhQCJeVIBAQaLD3eEbYk1ggQBAQEMAQEFHgkBAgEBhlsjNAk?=
 =?us-ascii?q?OAQMBAQEEAQEBAQMCARMBAQEmimcMgjopAYJnBic1HRALISUPFDQUgycBgWk?=
 =?us-ascii?q?BDBQPpXsWBQEXh0UKGYEWgT4GgTQBi14XeIEHhCM+gmEEGIIUgm+CJgSVHZU?=
 =?us-ascii?q?YCT6BWoIfhDWNRJdtlGyPcAIEBgUCFAGBUDeBWTMaI4M9i0WFXx8BMgGBBQE?=
 =?us-ascii?q?BjikBAQ?=
X-IPAS-Result: =?us-ascii?q?A2BqAABFuBtdjAVFDMBlHgEGBwaBUwkLAYJ0DFIyKIgXh?=
 =?us-ascii?q?QCJeVIBAQaLD3eEbYk1ggQBAQEMAQEFHgkBAgEBhlsjNAkOAQMBAQEEAQEBA?=
 =?us-ascii?q?QMCARMBAQEmimcMgjopAYJnBic1HRALISUPFDQUgycBgWkBDBQPpXsWBQEXh?=
 =?us-ascii?q?0UKGYEWgT4GgTQBi14XeIEHhCM+gmEEGIIUgm+CJgSVHZUYCT6BWoIfhDWNR?=
 =?us-ascii?q?JdtlGyPcAIEBgUCFAGBUDeBWTMaI4M9i0WFXx8BMgGBBQEBjikBAQ?=
X-IronPort-AV: E=Sophos;i="5.63,444,1557212400"; d="scan'208";a="408114829"
Received: from optima.cs.arizona.edu ([192.12.69.5])
 by mails1n0out.email.arizona.edu with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Jul 2019 13:07:22 -0700
Received: from lectura.cs.arizona.edu (lectura.cs.arizona.edu [192.12.69.186])
 by optima.cs.arizona.edu (8.14.4/8.14.4/Debian-2ubuntu2.1) with
 ESMTP id x62K7L6V023915
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 2 Jul 2019 13:07:22 -0700
Received: from lectura.cs.arizona.edu (localhost [127.0.0.1])
 by lectura.cs.arizona.edu (8.14.4/8.14.4/Debian-4.1ubuntu1.1) with ESMTP id
 x62K7LU1029771; Tue, 2 Jul 2019 13:07:21 -0700
Received: (from shijunxiao@localhost)
 by lectura.cs.arizona.edu (8.14.4/8.14.4/Submit) id x62K7LjD029770;
 Tue, 2 Jul 2019 13:07:21 -0700
Date: Tue, 2 Jul 2019 13:07:21 -0700
Message-Id: <201907022007.x62K7LjD029770@lectura.cs.arizona.edu>
In-Reply-To: <20190625150414.11332-1-zhouyates@gmail.com>
References: <20190625150414.11332-1-zhouyates@gmail.com>
From: Junxiao Shi <sunnylandh@gmail.com>
To: dev@dpdk.org
CC: Yangchao Zhou <zhouyates@gmail.com>, stephen@networkplumber.org,
 ferruh.yigit@intel.com, sodey@rbbn.com
Subject: Re: [dpdk-dev] [v3] kni: fix possible kernel crash with va2pa
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

I am battling a related problem as reported on
https://bugs.dpdk.org/show_bug.cgi?id=183 and this patch seems
relevant, so I applied this patch on 196a46fab6eeb3ce2039e3bcaca80f8ba43ffc8d

However, this patch does not work for me:
with CONFIG_RTE_LIBRTE_MBUF_DEBUG enabled, kni_free_mbufs's invocation of
rte_pktmbuf_free throws "bad mbuf pool" error.

While all mbufs and segments in kni->rx_q now have physical addresses,
the mbufs and segments placed back to kni->free_q still have (mis-)calculated
virtual address. The pa2va function is not working properly.

Consequently, userspace side is passing wrong pointer to rte_pktmbuf_free,
so that application crashes with CONFIG_RTE_LIBRTE_MBUF_DEBUG enabled.