DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source
Date: Wed, 3 Jul 2019 15:33:14 +0800	[thread overview]
Message-ID: <20190703073314.GA18868@___> (raw)
In-Reply-To: <CAJFAV8xnN5nDjDn+PngYHheP0un2tPS+RGx_AX36cMUCYGXmOg@mail.gmail.com>

Hi David,

On Wed, Jul 03, 2019 at 09:02:59AM +0200, David Marchand wrote:
> Hello,
> 
> On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie <tiwei.bie@intel.com> wrote:
> 
>     The value 40 used in VFIO_GET_REGION_ADDR() is a private value
>     (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It
>     is not part of VFIO API, and we should not depend on it.
> 
>     [1] https://github.com/torvalds/linux/blob/6fbc7275c7a9/drivers/vfio/pci/
>     vfio_pci_private.h#L19
> 
> 
> 
> I did not follow linux kernel changes, is there something that would change
> this offset?
> It looks like a cleanup (did not look into the details yet), do we need this
> now?

In VFIO/mdev [1], the offset can be something different. It depends
on the parent device. It's not just a cleanup. It's a preparation
for the mdev support in DPDK.

[1] https://github.com/torvalds/linux/blob/master/Documentation/vfio-mediated-device.txt

Thanks,
Tiwei

> 
> --
> David Marchand

  reply	other threads:[~2019-07-03  7:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03  5:45 Tiwei Bie
2019-07-03  7:02 ` David Marchand
2019-07-03  7:33   ` Tiwei Bie [this message]
2019-07-03  7:36     ` David Marchand
2019-07-03  7:56       ` Tiwei Bie
2019-07-03  8:01         ` David Marchand
2019-07-03  8:15           ` Tiwei Bie
2019-07-03  8:26             ` David Marchand
2019-07-03  8:59               ` Tiwei Bie
2019-07-03  9:10                 ` David Marchand
2019-07-03  9:25                   ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190703073314.GA18868@___ \
    --to=tiwei.bie@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).