From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75067A0487 for ; Thu, 4 Jul 2019 11:06:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 981E31B955; Thu, 4 Jul 2019 11:06:54 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id AC1461B203 for ; Thu, 4 Jul 2019 11:06:53 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id s15so5264066wmj.3 for ; Thu, 04 Jul 2019 02:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gejitMvwG5/qzhicqbcPsLaBGb/HWQIYsyyHp2XSOdY=; b=Tu5eyvYPP5BcANJliU96/JuNSF9S1Rtkz2D4hQzoB3jHvo6ssH+lU9ntU3tr7Illap z9baW6yPlwxvuIOYzbJ4OJ2PGLFfMuIgUXmLerbkRhha8ffnhyBwA2iJyhbzYy3qx6wH 4IkQ6N88QZ7VAJCKhJkgSRaJ0AP0XIdM+aD6FFPsmX+FRTS5uM+sJ12vmPEJsaAFs2eI HywHLaPP3KOYAnvXIaQrvy8OFO7NpF31lV8TkHfa/4nOZDK5+DkdZLqep40g226TxX2+ mYYosBo4KLTS/9hvTlj9wLc05I3Ma+dc+/aazHsssihPW8YE0ppp4inLJBXb87zbbR8I hbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gejitMvwG5/qzhicqbcPsLaBGb/HWQIYsyyHp2XSOdY=; b=kVMaNGSCeveG8G4WGRWPoJhHLfM7rXRf42Ovz9Jh0RhluDCQubqifn89mEMkj+E33C Reca/JwqADLykYJjn5H1Juj9cR52zp8mkzc0B2tNoeuUQuBOPsweLirL4iMpMWlxsEOn GAA/H3WLBHrZ2FjLyus/iUI2JBLuSoFrx7Ajs0+1fnoe0aRzqhBaiWO3umSgbJRKvOvk zpaaB8XCYjUmNxw4o9yf2nRZb0oLgo/dx/U/fAMjGNfLAz98aMu2E4eE0L7fYwa1IOh+ f+jJCyN/3l0mg4G+rpsl/2vb/vxf1F1tIQCsAewLu2hboRh0iZSmA/2Chs0dAs5eJBC+ 4nGQ== X-Gm-Message-State: APjAAAUaCZd3Epitxlj8d8BmEcpQoO6ZzGZ8RxVHGa/KoUtMf5UUqDe9 pYyFFhCxCFk4AEAu6OJU2+HVzg== X-Google-Smtp-Source: APXvYqxOTTyAHQA6XDbtAD6fqn2oilnQhx8zpiw7yxVPMQUTyR6zs66sLNRsfVGj9r8GWzxdNKGpcg== X-Received: by 2002:a1c:630a:: with SMTP id x10mr12490751wmb.113.1562231213347; Thu, 04 Jul 2019 02:06:53 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e7sm4446932wmd.0.2019.07.04.02.06.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2019 02:06:52 -0700 (PDT) Date: Thu, 4 Jul 2019 11:06:51 +0200 From: Adrien Mazarguil To: simei Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, dev@dpdk.org, Shahaf Shuler , Yongseok Koh Message-ID: <20190704090651.GJ4512@6wind.com> References: <1562215567-75436-1-git-send-email-simei.su@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562215567-75436-1-git-send-email-simei.su@intel.com> Subject: Re: [dpdk-dev] [RFC] ethdev: support symmetric hash function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 04, 2019 at 12:46:07PM +0800, simei wrote: > From: Simei Su > > Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. > To support symmetric hash by rte_flow RSS action, this RFC introduces > SYMMETRIC_TOEPLITZ to rte_eth_hash_function. > > Signed-off-by: Simei Su > --- > lib/librte_ethdev/rte_flow.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index f3a8fb1..e3c4fe5 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1744,6 +1744,7 @@ enum rte_eth_hash_function { > RTE_ETH_HASH_FUNCTION_DEFAULT = 0, > RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ > RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */ > + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ, /**< Symmetric TOEPLITZ */ "Symmetric TOEPLITZ" => "Symmetric Toeplitz." > RTE_ETH_HASH_FUNCTION_MAX, > }; Other than that, no problem with this change (no ABI impact, no need for deprecation). Please update testpmd a part of the same patch: - Wherever "toeplitz" is mentioned in test-pmd/cmdline.c. - Ditto for flow command, i.e. add ACTION_RSS_FUNC_SYMMETRIC_TOEPLITZ to test-pmd/cmdline_flow.c. - Update "set_hash_global_config" documentation section in testpmd_app_ug/testpmd_funcs.rst. Note to Shahaf/Yongseok, since mlx5 supports both but defaults to symmetric Toeplitz on vanilla Linux and standard Toeplitz when using OFED, how about using this chance to make the algorithm configurable as well? Thanks. -- Adrien Mazarguil 6WIND