From: Jack Min <jackmin@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ori Kam <orika@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6 4/4] app/testpmd: match GRE's key and present bits
Date: Fri, 5 Jul 2019 09:06:45 +0000 [thread overview]
Message-ID: <20190705090635.43zvptgrwfbj7goj@mellanox.com> (raw)
In-Reply-To: <20190705085835.GQ4512@6wind.com>
On Fri, 19-07-05, 10:58, Adrien Mazarguil wrote:
> On Fri, Jul 05, 2019 at 10:14:45AM +0800, Xiaoyu Min wrote:
> > support matching on GRE key and present bits (C,K,S)
> >
> > example testpmd command could be:
> > testpmd>flow create 0 ingress group 1 pattern eth / ipv4 /
> > gre / gre_key value is 0x12345678 / end
> > actions rss queues 1 0 end / mark id 196 / end
> >
> > Which will match GRE packet with k present bit set and key value is
> > 0x12345678.
> >
> > Acked-by: Ori Kam <orika@mellanox.com>
> > Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
>
> A few more nits below.
>
> [...]
> > @@ -1898,6 +1915,50 @@ static const struct token token_list[] = {
> > .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gre,
> > protocol)),
> > },
> > + [ITEM_GRE_C_RSVD0_VER] = {
> > + .name = "c_rsvd0_ver",
> > + .help = "GRE's first word (bit0 - bit15)",
>
> Help strings on existing fields should ideally be the same as their
> counterparts in rte_flow.h (shortened if necessary, not starting with a cap
> and not ending "."), in this case for instance:
>
Didn't know this before.
> .help =
> "checksum (1b), undefined (1b), key bit (1b),"
> " sequence number (1b), reserved 0 (9b),"
> " version (3b)",
>
I'll update.
> > + .next = NEXT(item_gre, NEXT_ENTRY(UNSIGNED), item_param),
> > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gre,
> > + c_rsvd0_ver)),
> > + },
> > + [ITEM_GRE_C_BIT] = {
> > + .name = "c_bit",
> > + .help = "GRE's C present bit",
>
> A bit odd, here's a suggestion:
>
> "checksum bit (C)".
>
I'll update.
> > + .next = NEXT(item_gre, NEXT_ENTRY(BOOLEAN), item_param),
> > + .args = ARGS(ARGS_ENTRY_MASK_HTON(struct rte_flow_item_gre,
> > + c_rsvd0_ver,
> > + "\x80\x00\x00\x00")),
> > + },
> > + [ITEM_GRE_S_BIT] = {
> > + .name = "s_bit",
> > + .help = "GRE's S present bit",
>
> Ditto:
>
> "sequence number bit (S)"
>
Ditto.
> > + .next = NEXT(item_gre, NEXT_ENTRY(BOOLEAN), item_param),
> > + .args = ARGS(ARGS_ENTRY_MASK_HTON(struct rte_flow_item_gre,
> > + c_rsvd0_ver,
> > + "\x10\x00\x00\x00")),
> > + },
> > + [ITEM_GRE_K_BIT] = {
> > + .name = "k_bit",
> > + .help = "GRE's K present bit",
>
> Ditto:
>
> "key bit (K)"
>
Ditto.
> > + .next = NEXT(item_gre, NEXT_ENTRY(BOOLEAN), item_param),
> > + .args = ARGS(ARGS_ENTRY_MASK_HTON(struct rte_flow_item_gre,
> > + c_rsvd0_ver,
> > + "\x20\x00\x00\x00")),
> > + },
> > + [ITEM_GRE_KEY] = {
> > + .name = "gre_key",
> > + .help = "match GRE Key",
>
> Nit: no caps for "Key" => "match GRE key"
>
OK.
> > + .priv = PRIV_ITEM(GRE_KEY, sizeof(rte_be32_t)),
> > + .next = NEXT(item_gre_key),
> > + .call = parse_vc,
> > + },
> > + [ITEM_GRE_KEY_VALUE] = {
> > + .name = "value",
> > + .help = "GRE key value",
>
> No need to repeat "GRE" here since it's already in GRE context:
>
> "key value"
>
OK.
> > + .next = NEXT(item_gre_key, NEXT_ENTRY(UNSIGNED), item_param),
> > + .args = ARGS(ARG_ENTRY_HTON(rte_be32_t)),
> > + },
>
> Also ITEM_GRE_KEY and ITEM_GRE_KEY_VALUE should come after ITEM_META_DATA to
> keep the same order as everywhere else.
>
Yes, it should be.
> Then assuming all the suggested changes are made:
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
Thank you!
> Note I did not look at mlx5 patches, please make sure someone has reviewed
> them. Thanks.
>
Yes, Slava will review them.
> --
> Adrien Mazarguil
> 6WIND
next prev parent reply other threads:[~2019-07-05 9:06 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 15:40 [dpdk-dev] [PATCH 0/4] ethdev: add GRE key field to flow API Xiaoyu Min
2019-06-24 15:40 ` [dpdk-dev] [PATCH 1/4] " Xiaoyu Min
2019-06-27 12:36 ` Ori Kam
2019-07-01 5:40 ` Ori Kam
2019-07-01 11:40 ` Jack Min
2019-06-24 15:40 ` [dpdk-dev] [PATCH 2/4] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-06-24 15:40 ` [dpdk-dev] [PATCH 3/4] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-06-24 15:40 ` [dpdk-dev] [PATCH 4/4] app/testpmd: " Xiaoyu Min
2019-07-01 13:11 ` [dpdk-dev] [PATCH v2 0/4] ethdev: add GRE key field to flow API Xiaoyu Min
2019-07-01 13:11 ` [dpdk-dev] [PATCH v2 1/4] " Xiaoyu Min
2019-07-01 13:11 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-01 13:11 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-01 13:11 ` [dpdk-dev] [PATCH v2 4/4] app/testpmd: " Xiaoyu Min
2019-07-02 3:08 ` [dpdk-dev] [PATCH v3 0/4] match on GRE's key Xiaoyu Min
2019-07-02 3:08 ` [dpdk-dev] [PATCH v3 1/4] ethdev: add GRE key field to flow API Xiaoyu Min
2019-07-02 3:08 ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-02 3:08 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-02 3:08 ` [dpdk-dev] [PATCH v3 4/4] app/testpmd: " Xiaoyu Min
2019-07-02 9:45 ` [dpdk-dev] [PATCH v4 0/4] match on GRE's key Xiaoyu Min
2019-07-02 9:45 ` [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API Xiaoyu Min
2019-07-03 14:06 ` Thomas Monjalon
2019-07-04 2:18 ` Jack Min
2019-07-03 15:25 ` Adrien Mazarguil
2019-07-04 2:43 ` Jack Min
2019-07-02 9:45 ` [dpdk-dev] [PATCH v4 2/4] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-02 9:45 ` [dpdk-dev] [PATCH v4 3/4] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-02 9:45 ` [dpdk-dev] [PATCH v4 4/4] app/testpmd: " Xiaoyu Min
2019-07-02 9:53 ` [dpdk-dev] [Suspected-Phishing][PATCH " Ori Kam
2019-07-03 15:25 ` [dpdk-dev] [PATCH " Adrien Mazarguil
2019-07-04 5:52 ` Jack Min
2019-07-04 9:52 ` Adrien Mazarguil
2019-07-04 11:56 ` Jack Min
2019-07-04 12:13 ` Adrien Mazarguil
2019-07-04 13:01 ` Jack Min
2019-07-04 16:30 ` [dpdk-dev] [PATCH v5 0/4] match on GRE's key Xiaoyu Min
2019-07-04 16:30 ` [dpdk-dev] [PATCH v5 1/4] ethdev: add GRE key field to flow API Xiaoyu Min
2019-07-04 16:30 ` [dpdk-dev] [PATCH v5 2/4] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-04 16:30 ` [dpdk-dev] [PATCH v5 3/4] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-04 16:30 ` [dpdk-dev] [PATCH v5 4/4] app/testpmd: " Xiaoyu Min
2019-07-05 2:14 ` [dpdk-dev] [PATCH v6 0/4] match on GRE's key Xiaoyu Min
2019-07-05 2:14 ` [dpdk-dev] [PATCH v6 1/4] ethdev: add GRE key field to flow API Xiaoyu Min
2019-07-05 8:39 ` Adrien Mazarguil
2019-07-05 2:14 ` [dpdk-dev] [PATCH v6 2/4] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-05 2:14 ` [dpdk-dev] [PATCH v6 3/4] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-05 2:14 ` [dpdk-dev] [PATCH v6 4/4] app/testpmd: " Xiaoyu Min
2019-07-05 8:58 ` Adrien Mazarguil
2019-07-05 9:06 ` Jack Min [this message]
2019-07-05 9:54 ` [dpdk-dev] [PATCH v7 0/4] match on GRE's key Xiaoyu Min
2019-07-05 9:54 ` [dpdk-dev] [PATCH v7 1/4] ethdev: add GRE key field to flow API Xiaoyu Min
2019-07-09 5:21 ` [dpdk-dev] [Suspected-Phishing][PATCH " Slava Ovsiienko
2019-07-05 9:54 ` [dpdk-dev] [PATCH v7 2/4] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-09 5:21 ` [dpdk-dev] [Suspected-Phishing][PATCH " Slava Ovsiienko
2019-07-05 9:54 ` [dpdk-dev] [PATCH v7 3/4] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-09 5:21 ` [dpdk-dev] [Suspected-Phishing][PATCH " Slava Ovsiienko
2019-07-05 9:54 ` [dpdk-dev] [PATCH v7 4/4] app/testpmd: " Xiaoyu Min
2019-07-09 5:21 ` [dpdk-dev] [Suspected-Phishing][PATCH " Slava Ovsiienko
2019-07-08 18:00 ` [dpdk-dev] [PATCH v7 0/4] match on GRE's key Ferruh Yigit
2019-07-09 9:02 ` [dpdk-dev] [PATCH v8 0/2] " Xiaoyu Min
2019-07-09 9:02 ` [dpdk-dev] [PATCH v8 1/2] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-09 9:02 ` [dpdk-dev] [PATCH v8 2/2] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-09 9:54 ` Thomas Monjalon
2019-07-09 10:46 ` Jack Min
2019-07-09 10:59 ` [dpdk-dev] [PATCH v9 0/2] match on GRE's key Xiaoyu Min
2019-07-09 10:59 ` [dpdk-dev] [PATCH v9 1/2] net/mlx5: support match GRE protocol on DR engine Xiaoyu Min
2019-07-09 10:59 ` [dpdk-dev] [PATCH v9 2/2] net/mlx5: match GRE's key and present bits Xiaoyu Min
2019-07-11 9:14 ` [dpdk-dev] [PATCH v9 0/2] match on GRE's key Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705090635.43zvptgrwfbj7goj@mellanox.com \
--to=jackmin@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).