DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, shreyansh.jain@nxp.com,
	hemant.agrawal@nxp.com,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names
Date: Fri,  5 Jul 2019 10:33:59 +0100	[thread overview]
Message-ID: <20190705093401.69913-1-bruce.richardson@intel.com> (raw)

The names of the rawdev drivers and the resultant libraries they built
were pretty inconsistent. In terms of directory names, some had "rawdev"
in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't.
Also, for the built .so/.a libraries, the names were not always
consistent between make and meson, as, while meson enforced a consistent
naming scheme, make did not, leading to differences - especially for
those drivers with "rawdev" in the directory name.

This patchset attempts to make things more standardized by removing
"rawdev" from all directory names - the drivers are in the "drivers/raw"
directory after all - and then standardizing the library names to
"librte_rawdev_<name>" for both make and meson.

Bruce Richardson (2):
  drivers/raw: remove rawdev from driver directory names
  drivers/raw: standardize name format of rawdev drivers

 drivers/raw/Makefile                                   |  4 ++--
 drivers/raw/dpaa2_cmdif/Makefile                       |  4 ++--
 ..._version.map => rte_rawdev_dpaa2_cmdif_version.map} |  0
 drivers/raw/dpaa2_qdma/Makefile                        |  4 ++--
 ...a_version.map => rte_rawdev_dpaa2_qdma_version.map} |  0
 drivers/raw/{ifpga_rawdev => ifpga}/Makefile           |  6 +++---
 drivers/raw/{ifpga_rawdev => ifpga}/base/Makefile      |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/README        |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.c   |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.h   |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_compat.h    |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_defines.h   |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.c |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.h |  0
 .../{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.c   |  0
 .../{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.h   |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme.c   |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_dperf.c |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_error.c |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_iperf.c |  0
 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_pr.c    |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_hw.h    |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_port.c  |  0
 .../{ifpga_rawdev => ifpga}/base/ifpga_port_error.c    |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/meson.build   |  0
 .../{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.c    |  0
 .../{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.h    |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.c  |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.h  |  0
 .../raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.c  |  0
 .../raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.h  |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.c |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.h |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.c    |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.h    |  0
 .../{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.c   |  0
 .../{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.h   |  0
 .../{ifpga_rawdev => ifpga}/base/opae_intel_max10.c    |  0
 .../{ifpga_rawdev => ifpga}/base/opae_intel_max10.h    |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_osdep.h  |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.c    |  0
 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.h    |  0
 .../base/opae_spi_transaction.c                        |  0
 .../base/osdep_raw/osdep_generic.h                     |  0
 .../base/osdep_rte/osdep_generic.h                     |  0
 drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.c     |  0
 drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.h     |  0
 drivers/raw/{ifpga_rawdev => ifpga}/meson.build        |  0
 .../rte_rawdev_ifpga_version.map}                      |  0
 drivers/raw/ioat/Makefile                              |  4 ++--
 ...md_ioat_version.map => rte_rawdev_ioat_version.map} |  0
 drivers/raw/meson.build                                |  6 +++---
 drivers/raw/{skeleton_rawdev => skeleton}/Makefile     |  4 ++--
 drivers/raw/{skeleton_rawdev => skeleton}/meson.build  |  0
 .../rte_rawdev_skeleton_version.map}                   |  0
 .../{skeleton_rawdev => skeleton}/skeleton_rawdev.c    |  0
 .../{skeleton_rawdev => skeleton}/skeleton_rawdev.h    |  0
 .../skeleton_rawdev_test.c                             |  0
 mk/rte.app.mk                                          | 10 +++++-----
 59 files changed, 21 insertions(+), 21 deletions(-)
 rename drivers/raw/dpaa2_cmdif/{rte_pmd_dpaa2_cmdif_version.map => rte_rawdev_dpaa2_cmdif_version.map} (100%)
 rename drivers/raw/dpaa2_qdma/{rte_pmd_dpaa2_qdma_version.map => rte_rawdev_dpaa2_qdma_version.map} (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/Makefile (82%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/Makefile (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/README (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_compat.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_defines.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_dperf.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_error.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_iperf.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_pr.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_hw.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_port.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_port_error.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/meson.build (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_intel_max10.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_intel_max10.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_osdep.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi_transaction.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/osdep_raw/osdep_generic.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/base/osdep_rte/osdep_generic.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.c (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.h (100%)
 rename drivers/raw/{ifpga_rawdev => ifpga}/meson.build (100%)
 rename drivers/raw/{ifpga_rawdev/rte_pmd_ifpga_rawdev_version.map => ifpga/rte_rawdev_ifpga_version.map} (100%)
 rename drivers/raw/ioat/{rte_pmd_ioat_version.map => rte_rawdev_ioat_version.map} (100%)
 rename drivers/raw/{skeleton_rawdev => skeleton}/Makefile (84%)
 rename drivers/raw/{skeleton_rawdev => skeleton}/meson.build (100%)
 rename drivers/raw/{skeleton_rawdev/rte_pmd_skeleton_rawdev_version.map => skeleton/rte_rawdev_skeleton_version.map} (100%)
 rename drivers/raw/{skeleton_rawdev => skeleton}/skeleton_rawdev.c (100%)
 rename drivers/raw/{skeleton_rawdev => skeleton}/skeleton_rawdev.h (100%)
 rename drivers/raw/{skeleton_rawdev => skeleton}/skeleton_rawdev_test.c (100%)

-- 
2.21.0


             reply	other threads:[~2019-07-05  9:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05  9:33 Bruce Richardson [this message]
2019-07-05  9:34 ` [dpdk-dev] [RFC PATCH 1/2] drivers/raw: remove rawdev from driver directory names Bruce Richardson
2019-07-05  9:34 ` [dpdk-dev] [RFC PATCH 2/2] drivers/raw: standardize name format of rawdev drivers Bruce Richardson
2019-07-05  9:35 ` [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names Bruce Richardson
2019-07-05  9:38   ` Thomas Monjalon
2019-07-05  9:39     ` Thomas Monjalon
2019-07-30  8:17       ` Thomas Monjalon
2019-07-30  9:42         ` Bruce Richardson
2019-07-30 12:20         ` Neil Horman
2019-07-30 13:28           ` Thomas Monjalon
2019-07-30 13:39 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2019-07-30 13:39   ` [dpdk-dev] [PATCH v2 1/2] drivers/raw: remove rawdev from directory names Thomas Monjalon
2019-07-31  7:28     ` Xu, Rosen
2019-07-30 13:39   ` [dpdk-dev] [PATCH v2 2/2] drivers/raw: standardize naming Thomas Monjalon
2019-07-31  7:29     ` Xu, Rosen
2019-07-31  8:27       ` Thomas Monjalon
2019-07-30 17:44   ` [dpdk-dev] [PATCH v2 0/2] standardize rawdev names Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190705093401.69913-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).