From: Tiwei Bie <tiwei.bie@intel.com>
To: "Yu, Jin" <jin.yu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Liu, Changpeng" <changpeng.liu@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] vhost: Add vhost-user-blk example which support inflight
Date: Thu, 11 Jul 2019 12:08:26 +0800 [thread overview]
Message-ID: <20190711040826.GA26516@___> (raw)
In-Reply-To: <B9FBC361811A3D4DBB02350807E29F7B0B930722@SHSMSX101.ccr.corp.intel.com>
On Thu, Jul 11, 2019 at 10:23:11AM +0800, Yu, Jin wrote:
> > -----Original Message-----
> > From: Bie, Tiwei
> > Sent: Wednesday, July 10, 2019 3:26 PM
> > To: Yu, Jin <jin.yu@intel.com>
> > Cc: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>;
> > maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>
> > Subject: Re: [PATCH v2 2/2] vhost: Add vhost-user-blk example which
> > support inflight
> >
> > On Wed, Jul 10, 2019 at 06:43:56PM +0800, JinYu wrote:
> > > A vhost-user-blk example that support inflight feature. It uses the
> > > new APIs that introduced in the first patch, so It can show how there
> > > APIs work to support inflight feature.
> > >
> > > Signed-off-by: JinYu <jin.yu@intel.com>
> > > ---
> > > V1 - add the case.
> > > ---
> > > examples/vhost_blk/Makefile | 67 +++
> > > examples/vhost_blk/blk.c | 118 ++++++
> > > examples/vhost_blk/blk_spec.h | 95 +++++
> > > examples/vhost_blk/meson.build | 20 +
> > > examples/vhost_blk/vhost_blk.c | 589 ++++++++++++++++++++++++++
> > > examples/vhost_blk/vhost_blk.h | 96 +++++
> > > examples/vhost_blk/vhost_blk_compat.c | 193 +++++++++
> > > 7 files changed, 1178 insertions(+)
> > > create mode 100644 examples/vhost_blk/Makefile create mode 100644
> > > examples/vhost_blk/blk.c create mode 100644
> > > examples/vhost_blk/blk_spec.h create mode 100644
> > > examples/vhost_blk/meson.build create mode 100644
> > > examples/vhost_blk/vhost_blk.c create mode 100644
> > > examples/vhost_blk/vhost_blk.h create mode 100644
> > > examples/vhost_blk/vhost_blk_compat.c
> > >
> > [...]
> >
> > I don't know much about SCSI yet. Could you provide some details about why
> > vhost-SCSI doesn't work with this inflight feature?
> We need the Qemu and vhost backend cooperate to support the inflight feature.
> So if we want to make it works, we need 2 patches, one is for Qemu, the other is for backend.
> Baidu has already submitted an vhost-user-blk patch to Qemu which is for this feature, that's why
> the vhost-user-blk example can support this feature.
So, we can't do it in vhost_scsi example just because we
don't have the corresponding support in QEMU? Technically,
is it possible to enable the inflight feature support for
vhost-user-scsi in QEMU?
Thanks,
Tiwei
next prev parent reply other threads:[~2019-07-11 4:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190708183959.50293>
2019-07-10 10:43 ` [dpdk-dev] [PATCH v2 1/2] vhost: support inflight share memory protocol feature JinYu
2019-07-10 7:18 ` Tiwei Bie
2019-07-11 2:09 ` Yu, Jin
2019-07-11 2:18 ` Tiwei Bie
2019-07-11 2:39 ` Yu, Jin
2019-07-11 4:09 ` Tiwei Bie
2019-07-10 10:43 ` [dpdk-dev] [PATCH v2 2/2] vhost: Add vhost-user-blk example which support inflight JinYu
2019-07-10 7:26 ` Tiwei Bie
2019-07-11 2:23 ` Yu, Jin
2019-07-11 4:08 ` Tiwei Bie [this message]
2019-07-11 12:11 ` Yu, Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711040826.GA26516@___ \
--to=tiwei.bie@intel.com \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).