From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FDE3A00E6 for ; Thu, 11 Jul 2019 06:10:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B8582C6A; Thu, 11 Jul 2019 06:10:06 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DC6552BAB for ; Thu, 11 Jul 2019 06:10:04 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 21:10:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="166275614" Received: from npg-dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.66]) by fmsmga008.fm.intel.com with ESMTP; 10 Jul 2019 21:10:02 -0700 Date: Thu, 11 Jul 2019 12:08:26 +0800 From: Tiwei Bie To: "Yu, Jin" Cc: "dev@dpdk.org" , "Liu, Changpeng" , "maxime.coquelin@redhat.com" , "Wang, Zhihong" Message-ID: <20190711040826.GA26516@___> References: <20190708183959.50293> <20190710104356.6580-1-jin.yu@intel.com> <20190710104356.6580-2-jin.yu@intel.com> <20190710072610.GA30767@___> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 2/2] vhost: Add vhost-user-blk example which support inflight X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 11, 2019 at 10:23:11AM +0800, Yu, Jin wrote: > > -----Original Message----- > > From: Bie, Tiwei > > Sent: Wednesday, July 10, 2019 3:26 PM > > To: Yu, Jin > > Cc: dev@dpdk.org; Liu, Changpeng ; > > maxime.coquelin@redhat.com; Wang, Zhihong > > Subject: Re: [PATCH v2 2/2] vhost: Add vhost-user-blk example which > > support inflight > > > > On Wed, Jul 10, 2019 at 06:43:56PM +0800, JinYu wrote: > > > A vhost-user-blk example that support inflight feature. It uses the > > > new APIs that introduced in the first patch, so It can show how there > > > APIs work to support inflight feature. > > > > > > Signed-off-by: JinYu > > > --- > > > V1 - add the case. > > > --- > > > examples/vhost_blk/Makefile | 67 +++ > > > examples/vhost_blk/blk.c | 118 ++++++ > > > examples/vhost_blk/blk_spec.h | 95 +++++ > > > examples/vhost_blk/meson.build | 20 + > > > examples/vhost_blk/vhost_blk.c | 589 ++++++++++++++++++++++++++ > > > examples/vhost_blk/vhost_blk.h | 96 +++++ > > > examples/vhost_blk/vhost_blk_compat.c | 193 +++++++++ > > > 7 files changed, 1178 insertions(+) > > > create mode 100644 examples/vhost_blk/Makefile create mode 100644 > > > examples/vhost_blk/blk.c create mode 100644 > > > examples/vhost_blk/blk_spec.h create mode 100644 > > > examples/vhost_blk/meson.build create mode 100644 > > > examples/vhost_blk/vhost_blk.c create mode 100644 > > > examples/vhost_blk/vhost_blk.h create mode 100644 > > > examples/vhost_blk/vhost_blk_compat.c > > > > > [...] > > > > I don't know much about SCSI yet. Could you provide some details about why > > vhost-SCSI doesn't work with this inflight feature? > We need the Qemu and vhost backend cooperate to support the inflight feature. > So if we want to make it works, we need 2 patches, one is for Qemu, the other is for backend. > Baidu has already submitted an vhost-user-blk patch to Qemu which is for this feature, that's why > the vhost-user-blk example can support this feature. So, we can't do it in vhost_scsi example just because we don't have the corresponding support in QEMU? Technically, is it possible to enable the inflight feature support for vhost-user-scsi in QEMU? Thanks, Tiwei