From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D838FA00E6 for ; Thu, 11 Jul 2019 17:34:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3C0C1B958; Thu, 11 Jul 2019 17:33:51 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by dpdk.org (Postfix) with ESMTP id 0BC1B31FC for ; Thu, 11 Jul 2019 17:33:49 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id m30so2928549pff.8 for ; Thu, 11 Jul 2019 08:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SLdk3d52DMLrtU4NEejAH5lWBSbWdndXju9w0LmfHcs=; b=cAZA7LOIoxPAPF6m5vEL4Wo56Ryft8oGs/6bA7RfVp0iztxu3L4TALJQBcoscOjOtp SiCeKS8lwd/hQEJ7uZGuEVCtCv4mr8MAO5Ff7RzydZSRpFaubjMbnqw4PaLLRAG7mLmL olAoBDfBGO1c+PtbZgLgasL/BtstY8REuthdjfoRxdQQf8PaiX63KXqi6cweRwBg7In6 hbNinTAsGro79aRgTwu0IkEkSyXXdpPlQVNl/hZ+EDFVlqNKII+Rp9No5FdXzrPoxFHy b62KXtpn7mRKlcL2CqjTjApJKHoMhBJYHgMOApL1bChMvQuDl5K50PGKaUBnvE0/phW8 6E1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SLdk3d52DMLrtU4NEejAH5lWBSbWdndXju9w0LmfHcs=; b=rpiQ00uWUaLKY056Ugbb3IUW4DkO+3n7WnPJTasG7OvsRfyJjcg0woBgJP7VmYf87x 4GaZPWIt+foawXfGQwRwEJmbQTNwIq2nAKEHsBEeBEuk8e3nH93xzn2MV+xP9l6N+eYH x+eGcgJ2fLqIxh93cmrxoV7lOC8d6ikW1MYW7DXADpJamnuHPNubrjM4Z6X2lmhgbrvI IyZ0wABeGCS4zHjS6bpjnVM+F+xaRd9FFwGYA7vWvcnve/3PB2R9u3n9Ljft+07SlxBk Es6z3Oast0QfGX8X4GDzy+lHIE4OjXmMUubNcGBtzFmE77EVSOephj9oBAYtHFBM1R4M pp0w== X-Gm-Message-State: APjAAAWG9OVW14SXvwtGXvjqFOK5SQenPVOAlfl3q8Rmiw3fTkcGAMsY yXhJ2ljEkNl2VApgTCQs0ZN4hiAi X-Google-Smtp-Source: APXvYqwf9583l+1Q9e5FsGNcsuLqLwfdcFaTTyB6mxa/cw5ON9EVcnro2OALOMMv0wXmBgdYeuouxQ== X-Received: by 2002:a63:3281:: with SMTP id y123mr4971169pgy.72.1562859229003; Thu, 11 Jul 2019 08:33:49 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u97sm5873629pjb.26.2019.07.11.08.33.48 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Jul 2019 08:33:48 -0700 (PDT) Date: Thu, 11 Jul 2019 08:31:19 -0700 From: Stephen Hemminger To: Olivier Matz Cc: "Wang, Haiyue" , "dev@dpdk.org" Message-ID: <20190711083119.018ff00d@hermes.lan> In-Reply-To: <20190711072619.fldr3dz7qblyvej5@glumotte.dev.6wind.com> References: <20190710092907.5565-1-olivier.matz@6wind.com> <20190711072619.fldr3dz7qblyvej5@glumotte.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 11 Jul 2019 09:26:19 +0200 Olivier Matz wrote: > For generic fields, I think they should be declared in this file. For > instance, if we decide to replace the current m->timestamp field by a > dynamic field, we should add like this: > > #define RTE_MBUF_DYN_TIMESTAMP_ID "rte_timestamp" > #define RTE_MBUF_DYN_TIMESTAMP_SIZE sizeof(uint64_t) > #define RTE_MBUF_DYN_TIMESTAMP_ALIGN __alignof__(uint64_t) Let's use structures (like rte_flow) rather that macros for this?