Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support

[Olivier Matz <olivier.matz@6wind.com>]

Hi,

On Tue, Jul 09, 2019 at 12:05:59PM +0100, Musatescu, Flavia wrote:
> 
> On 05/07/2019 14:58, Olivier Matz wrote:
> > - As "readlink -e" and "readlink -m" do not exist on freebsd,
> >    use "readlink -f", it should not have any impact in these cases.
> > - "sed -ri" is invalid on freebsd and should be replaced by
> >    "sed -ri=''"
> > - Use gmake instead of make.
> > 
> > This fixes the following command:
> >    SYSDIR=/usr/src/sys ./devtools/test-build.sh \
> >      -j4 x86_64-native-freebsd-gcc
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

(...)

> The example applications are being built in a wrong location when using the
> test-build.sh script on FreeBSD (“/app_name/x86_64-native-freebsd-gcc/”
> instead of “$(dpdk_path)/x86_64-native-freebsd-gcc/examples/app_name/x86_64-native-freebsd-gcc/”.
> 
> 
> The output build directory for the example applications is specified by
> O=$(readlink -f $dir/examples) variable inside the test-build.sh script. On
> FreeBSD "readlink -f" prints nothing when the file path doesn't exist, so
> the output build directory for each application ends up being configured to
> "/./app_name/x86_64-native-freebsd-gcc" (this is done inside the
> mk/rte.extsubdir.mk file).
> 
> A possible solution for this could be to modify the output directory to
> O=$(readlink -f $dir)/examples.

Thanks for spotting this. I will send a v3.