From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26736A00E6 for ; Fri, 12 Jul 2019 17:21:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38D251BDEC; Fri, 12 Jul 2019 17:21:13 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 304611BDE3 for ; Fri, 12 Jul 2019 17:21:12 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id b3so4932379plr.4 for ; Fri, 12 Jul 2019 08:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s6MsY/V7jauiPG0nCz17QAyLs5Lj1JRtCxOhJ/drhew=; b=gt32AY4nMbEhrdC2wDmH8KMio9pMmgJSP9mEN8gNgMQhAMqoK7BKxczpfYknBHAvyn 1CBWEG1HbMuApbrpTJjL1a/R/+Cx8JwqYpb6T5n7Ofl7pMY2Yokc7GF7gpHEp+bCpLpd u2sb0y+h7ChtMrGep+q0yXfiXFFzcIyQRGmMoRPkg6czOZd6AT4FJKTz1LrWFBNO5gP3 DRQPo50/YmCfq8GaN8zeFO5LKXXn7nomw0IUOL40pDX7HSz/vM+Ht6vXqPTCQECYUgN8 KTJAf20H0vk7QcdPzhYLX7J4fpSSITmU8JW9tbJ+CCszvzIjpBCUBeKoLBkvIdM6m5AL k4rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s6MsY/V7jauiPG0nCz17QAyLs5Lj1JRtCxOhJ/drhew=; b=SA9ScfoaWLXbH5Y7BWIbSCxPWCxyYhG7PPCDfn0iz03K1IoClxrCMTt/j7tYxjlXi+ mjJWZw9fSnBGOajCT2nku6Gy9toEuTX+kKdNbuBr0RO2UmZX/3P4wSaqBBiVMh9jeTQJ ZPbo7Dr7j1Irv+NspYk5WTkskuVwg40QG2i5e02LQmB07DFGMi52hHG9jy+RkgigzydG Jb55RhZZYXcyxvDNUBgCddD2R/mPM+KKGwfK0oK7bxbpmWnfwPqGUurohkcG9iffFzui VjxETTJXYvXsIlg5BzQ70b8wY8H/NHVycjhkKOwcRMkzvkA5/hMB9456OR4wN2XFHAIG rVeg== X-Gm-Message-State: APjAAAWjfYIVgLNyLysoCFEAXguwB75VWIAClssZq07y35MVB9xsTZLw un+TXPmVz18Sl4MyjyWGDbw= X-Google-Smtp-Source: APXvYqyGIJJdirVhWfYNhhnh3NtRY1ZpgW5dPVsQxt0WoDO8XPHbd/nG5r5XP+Iv8E69+zDD3uRAhA== X-Received: by 2002:a17:902:4c88:: with SMTP id b8mr12491776ple.29.1562944871259; Fri, 12 Jul 2019 08:21:11 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t8sm7116340pji.24.2019.07.12.08.21.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Jul 2019 08:21:11 -0700 (PDT) Date: Fri, 12 Jul 2019 08:21:04 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Ye Xiaolong , =?UTF-8?B?SsO6bGl1cw==?= Milan , dev@dpdk.org, qi.z.zhang@intel.com, david.marchand@redhat.com Message-ID: <20190712082104.1d35dfe7@hermes.lan> In-Reply-To: References: <20190712075546.GA20880@localhost.localdomain> <20190712154319.GA51076@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 12 Jul 2019 16:01:39 +0100 Ferruh Yigit wrote: > On 7/12/2019 4:43 PM, Ye Xiaolong wrote: > > Hi,=20 > >=20 > > Thanks for the patch. > >=20 > > On 07/12, J=C3=BAlius Milan wrote: =20 > >> Procedure xdp_get_channels_info was returning error code -1 in case of > >> ioctl command SIOCETHTOOL was not supported. This patch sets return > >> value back to 0 as it is valid case. > >> > >> Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue") > >> > >> Signed-off-by: J=C3=BAlius Milan =20 > > > >=20 > > Reviewed-by: Xiaolong Ye =20 >=20 > Applied to dpdk-next-net/master, thanks. The patch was broken. It would not set channel values correctly