[dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations

[dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations

[Stephen Hemminger]

Many drivers declare the local rte_vdev_driver structure
multiple times.  This is unnecessary.

Surprised it is so common, I guess everyone copies the same code.

Stephen Hemminger (9):
  net/tap: remove redundant declarations
  net/af_packet: remove redundant rte_vdev_driver declaration
  net/vhost: remove redundant rte_vdev_driver declaration
  net/null: remove redundant rte_vdev_driver declaration
  net/pcap: remove redundant rte_vdev_driver declaration
  net/ring: remove redundant rte_vdev_drive declaration
  net/virtio_user: remove redundant rte_vdev_driver declaration
  raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration
  raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration

 drivers/net/af_packet/rte_eth_af_packet.c     | 2 --
 drivers/net/null/rte_eth_null.c               | 2 --
 drivers/net/pcap/rte_eth_pcap.c               | 2 --
 drivers/net/ring/rte_eth_ring.c               | 2 --
 drivers/net/tap/rte_eth_tap.c                 | 2 --
 drivers/net/vhost/rte_eth_vhost.c             | 2 --
 drivers/net/virtio/virtio_user_ethdev.c       | 2 --
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c         | 3 ---
 drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 ---
 9 files changed, 20 deletions(-)

-- 
2.20.1

[dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations

[Stephen Hemminger]

The rte_vdev_drivers are declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/tap/rte_eth_tap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 3841842f01f8..64bd049110e1 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -71,8 +71,6 @@
 #define TAP_IOV_DEFAULT_MAX 1024
 
 static int tap_devices_count;
-static struct rte_vdev_driver pmd_tap_drv;
-static struct rte_vdev_driver pmd_tun_drv;
 
 static const char *valid_arguments[] = {
 	ETH_TAP_IFACE_ARG,
-- 
2.20.1

Re: [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations

[Wiles, Keith]

> On Jul 11, 2019, at 3:03 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> The rte_vdev_drivers are declared twice.
> The first one is not necessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 3841842f01f8..64bd049110e1 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -71,8 +71,6 @@
> #define TAP_IOV_DEFAULT_MAX 1024
> 
> static int tap_devices_count;
> -static struct rte_vdev_driver pmd_tap_drv;
> -static struct rte_vdev_driver pmd_tun_drv;
> 
> static const char *valid_arguments[] = {
> 	ETH_TAP_IFACE_ARG,
> -- 
> 2.20.1
> 
Acked-by: Keith Wiles <keith.wiles@intel.com>

Regards,
Keith

[dpdk-dev] [PATCH 2/9] net/af_packet: remove redundant rte_vdev_driver declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/af_packet/rte_eth_af_packet.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index db1a751cef5b..d2faefd9d724 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -526,8 +526,6 @@ open_packet_iface(const char *key __rte_unused,
 	return 0;
 }
 
-static struct rte_vdev_driver pmd_af_packet_drv;
-
 static int
 rte_pmd_init_internals(struct rte_vdev_device *dev,
                        const int sockfd,
-- 
2.20.1

[dpdk-dev] [PATCH 3/9] net/vhost: remove redundant rte_vdev_driver declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/vhost/rte_eth_vhost.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 0b61e37a1995..57f382c65ff5 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1199,8 +1199,6 @@ static const struct eth_dev_ops ops = {
 	.rx_queue_intr_disable = eth_rxq_intr_disable,
 };
 
-static struct rte_vdev_driver pmd_vhost_drv;
-
 static int
 eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
 	int16_t queues, const unsigned int numa_node, uint64_t flags)
-- 
2.20.1

[dpdk-dev] [PATCH 4/9] net/null: remove redundant rte_vdev_driver declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/null/rte_eth_null.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index f1b521a7564a..31cbb84d031d 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -490,8 +490,6 @@ static const struct eth_dev_ops ops = {
 	.rss_hash_conf_get = eth_rss_hash_conf_get
 };
 
-static struct rte_vdev_driver pmd_null_drv;
-
 static int
 eth_dev_null_create(struct rte_vdev_device *dev,
 		unsigned packet_size,
-- 
2.20.1

[dpdk-dev] [PATCH 5/9] net/pcap: remove redundant rte_vdev_driver declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/pcap/rte_eth_pcap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 26e85183e524..7ff6dc38dc9a 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -1085,8 +1085,6 @@ get_infinite_rx_arg(const char *key __rte_unused,
 	return 0;
 }
 
-static struct rte_vdev_driver pmd_pcap_drv;
-
 static int
 pmd_init_internals(struct rte_vdev_device *vdev,
 		const unsigned int nb_rx_queues,
-- 
2.20.1

Re: [dpdk-dev] [PATCH 5/9] net/pcap: remove redundant rte_vdev_driver declaration

[Ferruh Yigit]

On 7/11/2019 9:03 PM, Stephen Hemminger wrote:
> The rte_vdev_driver is declared twice.
> The first one is not necessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

[dpdk-dev] [PATCH 6/9] net/ring: remove redundant rte_vdev_drive declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/ring/rte_eth_ring.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 65c2813ba1bc..eb347bce61b7 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -248,8 +248,6 @@ static const struct eth_dev_ops ops = {
 	.mac_addr_add = eth_mac_addr_add,
 };
 
-static struct rte_vdev_driver pmd_ring_drv;
-
 static int
 do_eth_dev_ring_create(const char *name,
 		struct rte_ring * const rx_queues[],
-- 
2.20.1

Re: [dpdk-dev] [PATCH 6/9] net/ring: remove redundant rte_vdev_drive declaration

[Bruce Richardson]

On Thu, Jul 11, 2019 at 01:03:06PM -0700, Stephen Hemminger wrote:
> The rte_vdev_driver is declared twice.
> The first one is not necessary.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/ring/rte_eth_ring.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
> index 65c2813ba1bc..eb347bce61b7 100644
> --- a/drivers/net/ring/rte_eth_ring.c
> +++ b/drivers/net/ring/rte_eth_ring.c
> @@ -248,8 +248,6 @@ static const struct eth_dev_ops ops = {
>  	.mac_addr_add = eth_mac_addr_add,
>  };
>  
> -static struct rte_vdev_driver pmd_ring_drv;
> -
>  static int
>  do_eth_dev_ring_create(const char *name,
>  		struct rte_ring * const rx_queues[],
> -- 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

[dpdk-dev] [PATCH 7/9] net/virtio_user: remove redundant rte_vdev_driver declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/virtio/virtio_user_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 0a57db730cfd..3fc1725736b5 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -441,8 +441,6 @@ get_integer_arg(const char *key __rte_unused,
 	return 0;
 }
 
-static struct rte_vdev_driver virtio_user_driver;
-
 static struct rte_eth_dev *
 virtio_user_eth_dev_alloc(struct rte_vdev_device *vdev)
 {
-- 
2.20.1

[dpdk-dev] [PATCH 8/9] raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
index 42471fbd1187..586183a5b857 100644
--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
@@ -37,9 +37,6 @@ static uint16_t skeldev_init_once;
 /**< Rawdev Skeleton dummy driver name */
 #define SKELETON_PMD_RAWDEV_NAME rawdev_skeleton
 
-/**< Skeleton rawdev driver object */
-static struct rte_vdev_driver skeleton_pmd_drv;
-
 struct queue_buffers {
 	void *bufs[SKELETON_QUEUE_MAX_DEPTH];
 };
-- 
2.20.1

[dpdk-dev] [PATCH 9/9] raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration

[Stephen Hemminger]

The rte_vdev_driver is declared twice.
The first one is not necessary.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 05960cca95ed..3f42da1fed61 100644
--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -26,9 +26,6 @@ int dpaa2_cmdif_logtype;
 /* CMDIF driver name */
 #define DPAA2_CMDIF_PMD_NAME dpaa2_dpci
 
-/* CMDIF driver object */
-static struct rte_vdev_driver dpaa2_cmdif_drv;
-
 /*
  * This API provides the DPCI device ID in 'attr_value'.
  * The device ID shall be passed by GPP to the AIOP using CMDIF commands.
-- 
2.20.1

Re: [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations

[Ferruh Yigit]

On 7/11/2019 9:03 PM, Stephen Hemminger wrote:
> Many drivers declare the local rte_vdev_driver structure
> multiple times.  This is unnecessary.
> 
> Surprised it is so common, I guess everyone copies the same code.
> 
> Stephen Hemminger (9):
>   net/tap: remove redundant declarations
>   net/af_packet: remove redundant rte_vdev_driver declaration
>   net/vhost: remove redundant rte_vdev_driver declaration
>   net/null: remove redundant rte_vdev_driver declaration
>   net/pcap: remove redundant rte_vdev_driver declaration
>   net/ring: remove redundant rte_vdev_drive declaration
>   net/virtio_user: remove redundant rte_vdev_driver declaration
>   raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration
>   raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations

[Ferruh Yigit]

On 7/15/2019 5:18 PM, Ferruh Yigit wrote:
> On 7/11/2019 9:03 PM, Stephen Hemminger wrote:
>> Many drivers declare the local rte_vdev_driver structure
>> multiple times.  This is unnecessary.
>>
>> Surprised it is so common, I guess everyone copies the same code.

It seems it is common because a patchset explicitly added them [1] to set driver
name consistently, but later when another patch removed the related code [2] the
forward declarations seems forgotten to be removed.

I have updated commits to include the fixes lines so that they can be backported
(so that they don't cause additional conflicts for more serious patches in the
future.)

[1]: Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
[2]: Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev")


>>
>> Stephen Hemminger (9):
>>   net/tap: remove redundant declarations
>>   net/af_packet: remove redundant rte_vdev_driver declaration
>>   net/vhost: remove redundant rte_vdev_driver declaration
>>   net/null: remove redundant rte_vdev_driver declaration
>>   net/pcap: remove redundant rte_vdev_driver declaration
>>   net/ring: remove redundant rte_vdev_drive declaration
>>   net/virtio_user: remove redundant rte_vdev_driver declaration
>>   raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration
>>   raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Series applied to dpdk-next-net/master, thanks.
>