[dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue

[dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue

[Qiming Yang]

The return value of function ice_flow_valid_attr should
be non-zero. This patch fixed this issue.

Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: stable@dpdk.org

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
 drivers/net/ice/ice_generic_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index d5ff278..e6a2c4b 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,
 			rte_flow_error_set(error, EINVAL,
 					   RTE_FLOW_ERROR_TYPE_ACTION,
 					   actions, "Invalid queue ID for"
-					   " ethertype_filter.");
+					   " switch filter.");
 			return -rte_errno;
 		}
 		break;
@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
 	}
 
 	ret = ice_flow_valid_attr(attr, error);
-	if (!ret)
+	if (ret)
 		return ret;
 
 	inset = ice_flow_valid_pattern(pattern, error);
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue

[Ye Xiaolong]

Hi, qiming

On 07/12, Qiming Yang wrote:
>The return value of function ice_flow_valid_attr should
>be non-zero. This patch fixed this issue.
>

Minor nit about the title, 'issue' is never needed after word 'fix', what about

net/ice: fix flow validation failure ?

And for the commit log, it's unclear to me, I think what you want to say is 
function ice_flow_valid_attr will return a negative value on error, right?

>Fixes: d76116a4678f ("net/ice: add generic flow API")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>---
> drivers/net/ice/ice_generic_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
>index d5ff278..e6a2c4b 100644
>--- a/drivers/net/ice/ice_generic_flow.c
>+++ b/drivers/net/ice/ice_generic_flow.c
>@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,
> 			rte_flow_error_set(error, EINVAL,
> 					   RTE_FLOW_ERROR_TYPE_ACTION,
> 					   actions, "Invalid queue ID for"
>-					   " ethertype_filter.");
>+					   " switch filter.");
> 			return -rte_errno;
> 		}
> 		break;
>@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
> 	}
> 
> 	ret = ice_flow_valid_attr(attr, error);
>-	if (!ret)
>+	if (ret)
> 		return ret;
> 
> 	inset = ice_flow_valid_pattern(pattern, error);
>-- 
>2.7.4
>

For the patch,
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>