From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41137A00E6 for ; Fri, 12 Jul 2019 04:08:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88E274C8E; Fri, 12 Jul 2019 04:08:07 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 62F9E322C; Fri, 12 Jul 2019 04:08:05 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 19:08:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,480,1557212400"; d="scan'208";a="341567328" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.185]) by orsmga005.jf.intel.com with ESMTP; 11 Jul 2019 19:08:03 -0700 Date: Fri, 12 Jul 2019 16:49:52 +0800 From: Ye Xiaolong To: Qiming Yang Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20190712084952.GA47519@intel.com> References: <20190712013446.121853-1-qiming.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190712013446.121853-1-qiming.yang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, qiming On 07/12, Qiming Yang wrote: >The return value of function ice_flow_valid_attr should >be non-zero. This patch fixed this issue. > Minor nit about the title, 'issue' is never needed after word 'fix', what about net/ice: fix flow validation failure ? And for the commit log, it's unclear to me, I think what you want to say is function ice_flow_valid_attr will return a negative value on error, right? >Fixes: d76116a4678f ("net/ice: add generic flow API") >Cc: stable@dpdk.org > >Signed-off-by: Qiming Yang >--- > drivers/net/ice/ice_generic_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c >index d5ff278..e6a2c4b 100644 >--- a/drivers/net/ice/ice_generic_flow.c >+++ b/drivers/net/ice/ice_generic_flow.c >@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev, > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > actions, "Invalid queue ID for" >- " ethertype_filter."); >+ " switch filter."); > return -rte_errno; > } > break; >@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev, > } > > ret = ice_flow_valid_attr(attr, error); >- if (!ret) >+ if (ret) > return ret; > > inset = ice_flow_valid_pattern(pattern, error); >-- >2.7.4 > For the patch, Reviewed-by: Xiaolong Ye