From: Bruce Richardson <bruce.richardson@intel.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] examples/power: fix FreeBSD meson lib dependency
Date: Fri, 12 Jul 2019 10:22:28 +0100 [thread overview]
Message-ID: <20190712092228.GA532@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190712090651.11824-1-david.hunt@intel.com>
On Fri, Jul 12, 2019 at 10:06:51AM +0100, David Hunt wrote:
> Samples apps that depend on the power library should not build if
> the power library is not present. So now the following apps will
> check to see if it's built, else skip building.
> * l3fwd-pwer
> * vm_power_manager
> * guest_cli
>
> Fixes: e0130788576f ("examples/power: support meson/ninja build")
> Fixes: 89f0711f9ddf ("examples: build some samples with meson")
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> examples/l3fwd-power/meson.build | 6 ++++--
> examples/vm_power_manager/guest_cli/meson.build | 5 +++++
> examples/vm_power_manager/meson.build | 10 +++++++---
> 3 files changed, 16 insertions(+), 5 deletions(-)
>
Looks ok to me.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-07-12 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 9:06 David Hunt
2019-07-12 9:22 ` Bruce Richardson [this message]
2019-07-12 9:28 ` Ferruh Yigit
2019-07-12 23:23 ` Stephen Hemminger
2019-07-15 8:51 ` Hunt, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712092228.GA532@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).