From: Qiming Yang <qiming.yang@intel.com>
To: dev@dpdk.org
Cc: Qiming Yang <qiming.yang@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail
Date: Mon, 15 Jul 2019 10:23:56 +0800 [thread overview]
Message-ID: <20190715022356.73350-1-qiming.yang@intel.com> (raw)
In-Reply-To: <20190709040812.4191-1-qiming.yang@intel.com>
ice_flow_valid_attr will return zero on success and a
negative value on error. Current return value check
logical is opposite to the expected behavior. This
patch fixed this issue.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: stable@dpdk.org
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/ice/ice_generic_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index d5ff278..e6a2c4b 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
actions, "Invalid queue ID for"
- " ethertype_filter.");
+ " switch filter.");
return -rte_errno;
}
break;
@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
}
ret = ice_flow_valid_attr(attr, error);
- if (!ret)
+ if (ret)
return ret;
inset = ice_flow_valid_pattern(pattern, error);
--
2.7.4
next prev parent reply other threads:[~2019-07-15 2:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 4:08 [dpdk-dev] [PATCH] net/ice: fixed wrong return value Qiming Yang
2019-07-10 7:29 ` Thomas Monjalon
2019-07-11 2:58 ` Yang, Qiming
2019-07-15 2:23 ` Qiming Yang [this message]
2019-07-15 3:19 ` [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail Xing, Beilei
2019-07-15 5:59 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715022356.73350-1-qiming.yang@intel.com \
--to=qiming.yang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).