From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09877A0471 for ; Mon, 15 Jul 2019 16:45:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7A192C5E; Mon, 15 Jul 2019 16:45:32 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E74602C18 for ; Mon, 15 Jul 2019 16:45:30 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2019 07:45:20 -0700 X-IronPort-AV: E=Sophos;i="5.63,493,1557212400"; d="scan'208";a="172249432" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2019 07:45:19 -0700 Date: Mon, 15 Jul 2019 15:45:17 +0100 From: Bruce Richardson To: Marcin Zapolski Cc: dev@dpdk.org Message-ID: <20190715144516.GB548@bricha3-MOBL.ger.corp.intel.com> References: <20190715095623.579-1-marcinx.a.zapolski@intel.com> <20190715095623.579-3-marcinx.a.zapolski@intel.com> <20190715143956.GA548@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190715143956.GA548@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 2/3] examples/ip_fragmentation: remove usage of internal struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 15, 2019 at 03:39:56PM +0100, Bruce Richardson wrote: > On Mon, Jul 15, 2019 at 11:56:22AM +0200, Marcin Zapolski wrote: > > Modify ip_fragmentation example app to use rte_eth_info_get instead > > of global rte_eth_devices structure. > > > > Signed-off-by: Marcin Zapolski > > --- > > examples/ip_fragmentation/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c > > index 85c0100f7..a2a14e827 100644 > > --- a/examples/ip_fragmentation/main.c > > +++ b/examples/ip_fragmentation/main.c > > @@ -989,7 +989,7 @@ main(int argc, char **argv) > > if (rte_lcore_is_enabled(lcore_id) == 0) > > continue; > > > > - if (queueid >= rte_eth_devices[portid].data->nb_tx_queues) > > + if (queueid >= dev_info.nb_tx_queues) > > break; > > > > socket = (int) rte_lcore_to_socket_id(lcore_id); > > -- > > LGTM. > Acked-by: Bruce Richardson Forgot one minor comment. Suggest reword title to be "fix use of internal struct" and add fixes line below to commit body. Fixes: 9758b956dcf4 ("examples/ip_fragmentation: fix Tx queues init")