Re: [dpdk-dev] [PATCH v3 0/5] FSLMC bus enchancements

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Jul 16, 2019 at 03:36:53PM +0200, Thomas Monjalon wrote:
> 16/07/2019 13:40, Ferruh Yigit:
> > On 7/15/2019 10:53 PM, Thomas Monjalon wrote:
> > > 15/07/2019 10:44, Hemant Agrawal:
> > >> Nipun Gupta (1):
> > >>   bus/fslmc: use cinh read for eqcr ci on ls1088 platform
> > >>
> > >> Sachin Saxena (1):
> > >>   mempool/dpaa2: vfio dmamap for user allocated memory
> > >>
> > >> Shreyansh Jain (3):
> > >>   bus/fslmc: support device iteration
> > >>   bus/fslmc: enhance error handling for dev parsing
> > >>   bus/fslmc: dynamic iommu mode detection
> > > 
> > > I had the following comments on v1:
> > > 	The title should start with a verb.
> > > 	VFIO and DMA should be uppercase.
> > > I tried to fix it.
> > > 
> > > Applied, thanks
> > 
> > Getting build error with "ppc_64-power8-linuxapp-gcc" target [1], related to the
> > wrong format specifier. Not sure it is only ppc one.
> 
> It's so disappointing.
> I don't know how many times I tried to explain the issue with %lx.
> Should we just forbid %lx and %llx usage?
> 
We could, I suppose, so long as there never is a case where we actually do
use long, or long long variables. A checkpatch-style warning when one is
used probably is the best option, since it may help with catching these
earlier, while still allowing flexibility and human judgement as to whether
an instance is correct or not.

/Bruce