From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0EE1A0471 for ; Thu, 18 Jul 2019 16:41:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A1F52BC7; Thu, 18 Jul 2019 16:41:38 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 33B121B53 for ; Thu, 18 Jul 2019 16:41:37 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id b7so14019302pls.6 for ; Thu, 18 Jul 2019 07:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kToxuAD4WsmUnwTwF1VpUCRX0mPhazuGtZaT77HEAsE=; b=SLzPS4hFPP5L+pOGzrJxPi0GGBZ+U0q39Tyago0g0TdXpYKMVqLgdJZXjB+uxq5Aqv 7E8Dfwd5NRNCaPCaz/gJCBHowanY/dzXH/gG/SZaNBLin68uHZ7aBbRg0R1Ag6l6ly0K Tf1jG6opEF3s3BppPdAJ/C9Qdvgw4twH6HyZEWYVXXnGnLl1DXTuHZ+bX1OWleDC5Plu 5ZiLzhxR5i19QxMkZaGH7SL4HorQAufH6J8qHQM5kqZx12JqJAE8X0B0MfMdFWkp7uSK IhTa7ojlxmoaaVjnwFFdgL7CfR3qyQUtad6QfnGvDfptmVHqBXkgIFRMXpzuFN9m/CQQ J07w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kToxuAD4WsmUnwTwF1VpUCRX0mPhazuGtZaT77HEAsE=; b=ScYuTCwjcoRfvBhP/FHSx+3TaWk0CQNoBjlKceDpUlt6YXCIko/u7+Hh/9t9dbhtNU OAAI0UfpwYo7fskOm4Y261LXOKvnYMXozRo3UB4yQc3wqWL96Xra86EkM67QuRB14da4 qfb2Iqf9QkqW2u5H7csE7naVCTvwsytcjXH4Q1gRzB/v76jh72UnOqTKPNX51GXyZZUC JA6wOvJ7ahf/ILOTzwtBb0dI20r/Ag35EitEcn2FMdGhhUjFgMsiUMBZ/9t9WuR7+PMx 9SD2TyKF1GXt80+dEsVg+tgksaf1P86JzwOXsHdYK5nR0rtYRphe/rmuCD9kDatOhIDs Psyg== X-Gm-Message-State: APjAAAWYH/Wh698X3n80OojVYe45lPvstQhcHC+a5Hijj6GAwl5F794i 8+nIvUhKbVgoMJG9WtPzIVw= X-Google-Smtp-Source: APXvYqxT3mDvooebUhkMh7solAfziyXKkA4Lecxtrgo/+DIQlvsT6/SFTgmYubkvUUp1UGMw38gK9A== X-Received: by 2002:a17:902:a504:: with SMTP id s4mr28567568plq.117.1563460896198; Thu, 18 Jul 2019 07:41:36 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w1sm21836007pjt.30.2019.07.18.07.41.35 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 07:41:36 -0700 (PDT) Date: Thu, 18 Jul 2019 07:41:34 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20190718074134.1d43e39d@hermes.lan> In-Reply-To: <20190718143645.GA1641@bricha3-MOBL.ger.corp.intel.com> References: <20190716172741.21399-1-stephen@networkplumber.org> <20190718004822.25431-1-stephen@networkplumber.org> <20190718004822.25431-3-stephen@networkplumber.org> <20190718083111.GA1325@bricha3-MOBL.ger.corp.intel.com> <20190718073459.3004bb39@hermes.lan> <20190718143645.GA1641@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] cfgfile: use RTE_LOG for errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 18 Jul 2019 15:36:45 +0100 Bruce Richardson wrote: > On Thu, Jul 18, 2019 at 07:34:59AM -0700, Stephen Hemminger wrote: > > On Thu, 18 Jul 2019 09:31:11 +0100 > > Bruce Richardson wrote: > > > > > On Wed, Jul 17, 2019 at 05:48:21PM -0700, Stephen Hemminger wrote: > > > > In general, DPDK libraries to not print error messages to > > > > stdout because that is often redirected to /dev/null for daemons. > > > > This patch changes cfgfile library to use RTE_LOG with its > > > > own type. > > > > > > > > Signed-off-by: Stephen Hemminger > > > > --- > > > > lib/librte_cfgfile/Makefile | 1 + > > > > lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++--------- > > > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > > > > > diff --git a/lib/librte_cfgfile/Makefile b/lib/librte_cfgfile/Makefile > > > > index d9512565e559..4fc711778699 100644 > > > > --- a/lib/librte_cfgfile/Makefile > > > > +++ b/lib/librte_cfgfile/Makefile > > > > @@ -11,6 +11,7 @@ LIB = librte_cfgfile.a > > > > CFLAGS += -O3 > > > > CFLAGS += $(WERROR_FLAGS) > > > > CFLAGS += -I$(SRCDIR)/../librte_eal/common/include > > > > +LDFLAGS += -lrte_log > > > > > > > Where does this come from, there is no separate log library in DPDK? > > > > I saw a build failure with previous patch about rte_log not being > > present. > > I can believe that, it's just how does this help? What does the linker pick > up when you pass this? I don't think it helps, it was an ICC only error and it was purely a guess since I don't have ICC. Let me take it off in the next version and see what CI says.